1614235 - View source: fix line wrapping option

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

The view source window respects view_source.wrap_long_lines, but the UI for it has been broken and hidden for some time.

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Attachment: 1614235-view-source-1.diff

• Fixes the line wrapping, most of which is handled by the view source actor, but I can't tap into the actor to do what I want. I've added "wrap long lines" back to the View menu.
• Removes the context menu. I don't see the use in keeping it when all of the items that work are available from the main menu, and there are several items that don't work (and are irrelevant anyway).
• Removes some items from the Edit menu which make no sense in a read-only context.
• Fixes the print preview toolbar which was meant to happen with the last bug, but I changed an identifier at some point and broke it.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9127460 [details] [diff] [review]
1614235-view-source-1.diff

Review of attachment 9127460 [details] [diff] [review]:
-----------------------------------------------------------------

The context menu on trunk is wrong, but it would be  nice to keep Copy/Select All (and maybe Find Again) like 68.
The other fixes look good. r=mkmelin if you add back the above

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/231dc57f3704
View source: fix line wrapping option, remove pointless menu items. r=mkmelin DONTBUILD

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/228fc7494fb8
followup to fix linting. rs=eslint DONTBUILD