1614307 - Replace MOZ_ASSERT with static_assert where appropriate

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1614307 - Part 1: Use constexpr for remaining constants in x86/x64 assemblers. r=tcampbell!

const and constexpr is interchangeable for integral values, but it seems
cleaner to use constexpr throughout the files.

Depends on D62241

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1614307 - Part 2: Use static_assert for Register64 comparison. r=tcampbell!

Depends on D62242

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1614307 - Part 3: Use static_assert for Rabaldr scratch registers assertions. r=tcampbell!

Register::FromCode() can't be changed to constexpr due to GCC limitations (bug 1594094).

Depends on D62243

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1614307 - Part 4: Use static_assert for codegen and lowering assertions. r=tcampbell!

The "None" architecture assembler provides Registers::invalid_reg2 in addition to
Registers::invalid_reg as an alternative invalid register, cf. ReturnReg in
"js/src/jit/none/MacroAssembler-none.h".

Depends on D62244

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1614307 - Part 5: Replace MOZ_ASSERT with static_assert in js/src/jit. r=tcampbell!

These assertions can be changed to static_assert without any extra modifications.

Depends on D62245

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7abd7df2c324
Part 1: Use constexpr for remaining constants in x86/x64 assemblers. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8adbf3e8eeae
Part 2: Use static_assert for Register64 comparison. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/48193b821c44
Part 3: Use static_assert for Rabaldr scratch registers assertions. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/dd1ac96c922d
Part 4: Use static_assert for codegen and lowering assertions. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/4b390fa44646
Part 5: Replace MOZ_ASSERT with static_assert in js/src/jit. r=tcampbell

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7abd7df2c324
https://hg.mozilla.org/mozilla-central/rev/8adbf3e8eeae
https://hg.mozilla.org/mozilla-central/rev/48193b821c44
https://hg.mozilla.org/mozilla-central/rev/dd1ac96c922d
https://hg.mozilla.org/mozilla-central/rev/4b390fa44646