161449 - Non-ASCII shortcuts for select elements in html forms

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Boris 'pi' Piwinger]

Happening in all versions I have seen including current nightlies. Probably a
dupe, but I cannot find it.

Look at any form which has a select field (like the URL above). Using
letter-keys you can jump to the first entry starting with that letter. This does
not work for non-ASCII characters. Most often I see this for country selection,
where I press ö for Österreich (german for Austria).

pi

Comment 1

[Aaron Leventhal]

Kyle, will you take this?

Comment 2

[Kyle Yuan]

Hmm, I think this double-bytes navigation should be a future work.

Comment 3

[Aaron Leventhal]

Kyle, do you mean you want to mark it "Future" in the target milestone? If
that's what you mean, then you can also mark the Priority P1-P5, and select the
"accept bug" radio button.

Comment 4

[Kyle Yuan]

Yes, I know this rule, but I'm afraid I'll do that in a far future :(

Comment 5

[Aaron Leventhal]

Frank, do you have someone on the i18n team who can take this?

Comment 6

[Kyle Yuan]

if bug 150590 and bug 168281 got fixed, this one would be fixed easily. 
taking...

Comment 7

[Boris 'pi' Piwinger]

Kyle, do you mean you want the bug ASSIGNED to you by "taking"?

BTW: In comment 2, you talk about "double-bytes". ö is just one byte in
iso-8859-1. Or do I mix something up?

pi

Comment 8

[Kyle Yuan]

Yes, this bug is assigned to me. I want to solve this problem entirely no matter
the char is single-byte or double byte. 

Comment 9

[Kyle Yuan]

Attachment: fix nsCRT::ToLower bug

nsCRT::ToLower(char aChar) use this method to convert a char to lower case:
-- return (char)kUpper2Lower[aChar];
this will be failed when aChar >= 128

I want to fix this Non-ASCII char problem here and file a new bug for the IME
support, because we need to support IME not only for <select>, but also for
other widget, such as <menu>, <tree>, <listbox>

Seeking r=

Comment 10

[Kyle Yuan]

Attachment: fix nsCRT::ToLower bugs and use |ToLowerCase()| instead of |nsCRT::ToLower()|

seeking r=

Comment 11

[Aaron Leventhal]

Comment on attachment 100839 [details] [diff] [review]
fix nsCRT::ToLower bugs and use |ToLowerCase()| instead of |nsCRT::ToLower()|

r=aaronl

Thank you for also fixing nsCRT::ToLower() even though you don't use it in this
code anymore.

Comment 12

[Alec Flett]

Comment on attachment 100839 [details] [diff] [review]
fix nsCRT::ToLower bugs and use |ToLowerCase()| instead of |nsCRT::ToLower()|

sr=alecf
nice work.
I'd love to get rid of kUpperToLower/etc entirely and just use a similar
formula to the stuff in string/public

Comment 13

[Alec Flett]

yeah, I also see what are probably other invalid casts to the 8-bit nsCRT::ToLower:
http://lxr.mozilla.org/seamonkey/search?string=nscrt%3A%3Atolower

(though maybe at this point we should just file a new bug for those)

Comment 14

[Kyle Yuan]

checked in!

will file a new bug as per comment 12 and 13.

Comment 15

[Boris 'pi' Piwinger]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.2b) Gecko/2002092904

Marking verified as reporter.

pi