1614549 - Highlight DOM elements from instant evaluation

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Do you mean we should automatically highlight the element as soon as it is rendered in the eager evaluation result?
or do you mean it should have the same functionality as logged element in the output (hovering highlights them, clicking on the icon jump to inspector) ?
That's something we could also have in the autocomplete popup (as you navigate in it, we could highlight the element in the page)

Comment 2

[:Harald Kirschner :digitarald]

Do you mean we should automatically highlight the element as soon as it is rendered in the eager evaluation result?

If the current expression points to an element, it should be highlighted, yes. I recommend giving it a spin in Chrome.

or do you mean it should have the same functionality as logged element in the output (hovering highlights them, clicking on the icon jump to inspector) ?

No, hover should NOT be required.

That's something we could also have in the autocomplete popup (as you navigate in it, we could highlight the element in the page)

Yes. I thought this would be mostly covered by instant evaluation; as the autocomplete triggers it – but having something separate could also work. For which use cases would we need highlighting via autocomplete vs instant eval?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

For which use cases would we need highlighting via autocomplete vs instant eval?

when the user disabled instant eval maybe?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1614549 - Highlight DOM elements from instant evaluation. r=jlast.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a169b2355d8d
Highlight DOM elements from instant evaluation. r=jlast.

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a169b2355d8d

Comment 7

[Oriol Brufau [:Oriol]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #1)

Do you mean we should automatically highlight the element as soon as it is rendered in the eager evaluation result?

I would definitely prefer this. If I want to evaluate document.body.offsetWidth, between typing document.body and adding the 2nd . the whole screen will flicker blue. This will be unexpected and will interrupt me.

(In reply to :Harald Kirschner :digitarald from comment #2)

No, hover should NOT be required.

That's so visually disrupting. Hover should be required.

Comment 8

[:Harald Kirschner :digitarald]

I would definitely prefer this. If I want to evaluate document.body.offsetWidth, between typing document.body and adding the 2nd . the whole screen will flicker blue. This will be unexpected and will interrupt me.

This landed and I don't see flickering. Is there an STR I am missing?

Comment 9

[Oriol Brufau [:Oriol]]

Attachment: annoyance.webm

I mean this. I just want to see document.body.offsetHeight, but while typing it the page becomes blue temporarily.