1614712 - Add a requestId to the profiler's WebChannel messages

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P2)

Description

[Greg Tatum [:gregtatum]]

I missed some feedback to add a requestId when I initially landed the WebChannels.

https://github.com/firefox-devtools/profiler/pull/2334#discussion_r358826609

This bug will add it to the implementation.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1614712 - Add a requestId to the profiler's WebChannel messages; r?julienw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33b7e55476b4
Add a requestId to the profiler's WebChannel messages; r=julienw

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/33b7e55476b4

Comment 4

[Alice0775 White]

Hi, "Firefox Profiler" seems to use the built-in one by default. Even if I enable it, the previous installed "Gecko Profiler WebExtension" remains without being deleted.

Is "Gecko Profiler WebExtension" obsolete? Can I remove it from about:addons?

(ref https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Profiling_with_the_Built-in_Profiler#Using_the_Firefox_Profiler)

Comment 5

[Julien Wajsberg [:julienw]]

Hey Alice,
The path using the built-in popup is still changing rapidly these days, that's why it's been enabled on Nightly only for now and we're still recommending using the add-on. We're working on a migration path for the add-on users that would remove the add-on once we feel the moment is right, which should happen in the few coming months.
That said, if you use the built-in one and you're happy with it, you can safely remove the addon.

Comment 6

[Alice0775 White]

okay thanks