1614761 - Port content-refreshblocker.js refresh blocking to Fission

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[Neil Deakin]

This is used I think to prevent pages from reloading. This bug is about converting it to JSWindowActor and verifying what needs to be done for fission.

The content code is in content-refreshblocker.js

Comment 1

[Chris Peterson [:cpeterson]]

kmag and Nika ask whether reloading even applies to subframes.

Tracking for Fission Nightly (M6)

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for Fission M6b Nightly milestone.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[Neha Kochar [:neha]]

Seems to be affecting only top level window reloads. Jamie, please confirm that this will not be critical to fix for Fission.

Comment 5

[James Teh [:Jamie]]

This was implemented many years ago in bug 83265. It doesn't look like the preference is exposed through UI any more, though I can't find where it was removed. Also, I haven't seen many sites use meta refresh these days, though I have no data for that.

The above does suggest it's not critical for Fission release. That said, we have no telemetry for this, so it's possible there are still users who use this.

Asa, thoughts?

Comment 6

[James Teh [:Jamie]]

Also, NI Marco for his thoughts.

Comment 7

[Marco Zehe (:MarcoZ)]

I don't think I've seen this meta refresh being used anywhere for years. If updates happen nowadays, they happen dynamically with JS, and are thus much less intrusive.

Comment 8

[Neil Deakin]

Gijs describes the reasoning for removing the UI for this at https://bugzilla.mozilla.org/show_bug.cgi?id=1365133#c260

That said, I have a patch that implements this already.

Comment 9

[Neil Deakin]

Attachment: Bug 1614761, move refresh blocking handling from framescript to an actor, r=gijs

Comment 10

[Neil Deakin]

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1660331 on refresh blocking UI not appearing in subframes.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71dbed0305a2
move refresh blocking handling from framescript to an actor, r=Gijs

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/71dbed0305a2