Run `./mach addtest` with Python 3
Categories
(Testing :: General, task)
Tracking
(firefox75 fixed)
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: ahal, Assigned: hamzah18051, Mentored)
References
Details
Attachments
(1 file)
To get this command running in Python 3, remove it from the blacklist in the root topsrcdir/mach driver. Then try running it with ./mach addtest. Expect errors, and fix them as you run into them. Be sure to try out all arguments / options on the command line. See the --help for a reference.
The main implementation is in testing/mach_commands.py (look for the AddTest class). Please note that file still contains Python 2 commands, so anything that runs at import time will need to be compatible with both 2 and 3 until everything is switched over. The addtest implementation itself can be Python 3 only.
|
Reporter | |
Comment 1•4 years ago
|
||
Hey Hamzah, this might be a good one to help get you started. Let me know if you need a hand with the contribution process or anything else.
p.s I think I accidentally closed a chat window with you on Riot.. but feel free to reach out to me there again too.
|
Assignee | |
Comment 2•4 years ago
|
||
I'll start working on it and put a PR as soon as I am done.
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/752a464c8ec8 Run `./mach addtest` with Python 3 r=ahal
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Description
•