SVG Text is blurry with WebRender enabled
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
People
(Reporter: dholbert, Assigned: hiro)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 files)
[Spinning this off from bug 1610441]
STR:
(1) Enable WebRender
(2) Load attached testcase (taken from https://commitlint.js.org/assets/commitlint.svg )
(3) Look at the text. Compare to the same STR with WebRender disabled.
ACTUAL RESULTS:
Text is noticeably blurrier when WebRender is enabled.
EXPECTED RESULTS:
No such blurriness.
Reporter | ||
Comment 1•4 years ago
|
||
Here's a screenshot showing what the blurry text looks like (taken from https://github.com/webcompat/web-bugs/issues/47645 )
I can reproduce this blurriness locally on Linux Ubuntu 19.10, FWIW (tested yesterday with yesterday's nightly). By default, I don't have WebRender enabled; but when I enable it (by setting gfx.webrender.all = true
in about:config) and restart Firefox, then I do see blurriness like this.
Comment 2•4 years ago
|
||
Comment 3•4 years ago
|
||
baseSyle is null here
and so we think that the scale of the main element is animated, which causes us to try to clamp it to a factor based on the window size in ChooseScale. The scale is not actually changing, and this seems more like a fallback that is not expected to happen.
Assignee | ||
Comment 4•4 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #0)
Created attachment 9125930 [details]
testcase 1[Spinning this off from bug 1610441]
STR:
(1) Enable WebRender
(2) Load attached testcase (taken from https://commitlint.js.org/assets/commitlint.svg )
Note that to reproduce this issue, we need to open this attachment in a new tab.
Comment 5•4 years ago
|
||
Fairly minimal testcase to reproduce hitting the baseStyle.IsNull case.
Assignee | ||
Comment 6•4 years ago
|
||
I was misremembering about the baseStyle
, it's only valid only if there is a additive/accumulate animations. I've filed bug 1615156 for that.
But it's not the culprit of this issue. Looks like AnimationValue::GetScaleValue is totally broken (in SVG document?). And for non-WebRender cases, there is a (some) wallpaper to obscure the GetScaleValue issue.
Assignee | ||
Comment 7•4 years ago
|
||
Hmm, the patch for bug 1615156 fixed this issue too. :p I am missing something...
Comment 8•4 years ago
|
||
Not really important now but just wanted to post some regression range history stuff I found for posterity.
Testcase went from crisp to fuzzy:
2018-12-22
Bug 1415987
Testcase went from fuzzy to super super blurry:
2019-01-18
not sure what in that range caused it
Testcase went super super blurry back to blurry:
2019-08-12
Bug 1569215
Updated•4 years ago
|
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cbcb3a03f665 Add reftest.
Comment 12•4 years ago
|
||
bugherder |
Description
•