Closed Bug 1614788 Opened 4 years ago Closed 4 years ago

SVG Text is blurry with WebRender enabled

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1615156

People

(Reporter: dholbert, Assigned: hiro)

References

(Regression)

Details

(Keywords: regression)

Attachments

(4 files)

Attached image testcase 1

[Spinning this off from bug 1610441]

STR:
(1) Enable WebRender
(2) Load attached testcase (taken from https://commitlint.js.org/assets/commitlint.svg )
(3) Look at the text. Compare to the same STR with WebRender disabled.

ACTUAL RESULTS:
Text is noticeably blurrier when WebRender is enabled.

EXPECTED RESULTS:
No such blurriness.

Here's a screenshot showing what the blurry text looks like (taken from https://github.com/webcompat/web-bugs/issues/47645 )

I can reproduce this blurriness locally on Linux Ubuntu 19.10, FWIW (tested yesterday with yesterday's nightly). By default, I don't have WebRender enabled; but when I enable it (by setting gfx.webrender.all = true in about:config) and restart Firefox, then I do see blurriness like this.

baseSyle is null here

https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/dom/animation/KeyframeEffect.cpp#1794

and so we think that the scale of the main element is animated, which causes us to try to clamp it to a factor based on the window size in ChooseScale. The scale is not actually changing, and this seems more like a fallback that is not expected to happen.

Flags: needinfo?(hikezoe.birchill)

(In reply to Daniel Holbert [:dholbert] from comment #0)

Created attachment 9125930 [details]
testcase 1

[Spinning this off from bug 1610441]

STR:
(1) Enable WebRender
(2) Load attached testcase (taken from https://commitlint.js.org/assets/commitlint.svg )

Note that to reproduce this issue, we need to open this attachment in a new tab.

Attached image s.svg

Fairly minimal testcase to reproduce hitting the baseStyle.IsNull case.

See Also: → 1615156

I was misremembering about the baseStyle, it's only valid only if there is a additive/accumulate animations. I've filed bug 1615156 for that.

But it's not the culprit of this issue. Looks like AnimationValue::GetScaleValue is totally broken (in SVG document?). And for non-WebRender cases, there is a (some) wallpaper to obscure the GetScaleValue issue.

Hmm, the patch for bug 1615156 fixed this issue too. :p I am missing something...

Flags: needinfo?(hikezoe.birchill)
Regressed by: 1415987
Has Regression Range: --- → yes
Keywords: regression
Assignee: nobody → hikezoe.birchill
Depends on: 1615156
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: