Closed Bug 1614841 Opened 1 year ago Closed 1 year ago

Case-insensitive autocompletes cause reference errors

Categories

(DevTools :: Console, defect, P3)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: Harald, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1614841 - Fix eager evaluation result for case-insensitive autocomplete results. r=Honza.
47 bytes, text/x-phabricator-request
Details | Review

What were you doing?

  1. Type doc in Console
  2. Select DocumentFragment

What happened?

Autocomplete incorrectly uses lowercase d and evals documentFragment.

ReferenceError: "documentFragment is not defined"

What should have happened?

Eager eval for DocumentFragment.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

The autocomplete popup does a case-insensitive match, so
some items could end up changing the final input value.
This is already handled when selecting an autocomplete item,
but it wasn't the case for the eager evaluation.
This patch moves the code of the acceptCompletion function
to another function, that we can then call from the eager
evaluation updates.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90a1f213a11a
Fix eager evaluation result for case-insensitive autocomplete results. r=Honza.
Duplicate of this bug: 1615032

https://hg.mozilla.org/mozilla-central/rev/90a1f213a11a

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Regressions: 1624333
You need to log in before you can comment on or make changes to this bug.