Closed Bug 1614876 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21748 - SharedWorker: Give identical names to each shared workers in WPT

Categories

(Core :: DOM: Workers, task, P4)

Product:
Core
Component:
DOM: Workers
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21748 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21748
Details from upstream follow.

Eriko Kurimoto <elkurin@google.com> wrote:

SharedWorker: Give identical names to each shared workers in WPT

This CL adds names to each shared workers in shared-worker-options-type.html.

Without specifying name, all tests were accessing to the same worker
because they are matched to an existing shared worker whose name, url
and origin. (We were not checking type or credentials.)
Therefore, tests for { type: 'module' } were actually not testing module
shared worker, and just accessing to the classic shared worker created
by the first test.

This test will fail (timeout) after implementing this spec change:
https://github.com/whatwg/html/pull/5258

Bug: n/a
Change-Id: I7b5ea901b07cfb9f5b73e8948e1e7757ab7c5c34

Reviewed-on: https://chromium-review.googlesource.com/2050051
WPT-Export-Revision: 71d4dde63292b92302be80fca9a01fce5aca30f4

Component: web-platform-tests → DOM: Workers
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 45 tests

Status Summary

Firefox

OK : 1
PASS: 3[GitHub] 47[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 2

Chrome

OK : 1
PASS: 4
FAIL: 1

Safari

OK : 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/workers/modules/shared-worker-options-type.html
Test worker construction with an empty worker type.: FAIL (Chrome: PASS, Safari: FAIL)
Test worker construction with an unknown worker type.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/650c15a0638f
[wpt PR 21748] - SharedWorker: Give unique names to each shared workers in shared-worker-options-type.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/650c15a0638f

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.