Closed
Bug 1614918
Opened 4 years ago
Closed 4 years ago
Stop waiting for synchronous removeTab method in inspector init
Categories
(DevTools :: Inspector, task, P3)
DevTools
Inspector
Tracking
(firefox75 fixed)
RESOLVED
FIXED
Firefox 75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
The following method is marked as async but is actually synchronous:
https://searchfox.org/mozilla-central/source/devtools/client/inspector/toolsidebar.js#156-160
async removeTab(tabId, tabPanelId) {
this._tabbar.removeTab(tabId);
this.emit("tab-unregistered", tabId);
},
This single async method makes the inspector initialization look more asynchronous than it should. As I aim to simplify it in Bug 1611096, I would like to get rid of this complexity asap.
Note: it was initially synchronous when sidebar panels could use iframes, but the related code was removed in Bug 1567860.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e84a0546e6e2 Stop waiting for synchronous removeTab method in inspector init r=pbro
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in
before you can comment on or make changes to this bug.
Description
•