1614927 - Don't suggest "No username" entries in the "Fill Login" context menu for username fields

Status: RESOLVED WONTFIX

(Toolkit :: Password Manager, defect)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Recording of the issue

Affected platforms:
Windows 10 x64

Affected versions:
All

Steps to reproduce:

1. Launch Firefox
2. Go facebook.com, twitter or wikipedia
3. Save 1 password entry without a username (password generation works too)
4. Optional Save 1 set of credentials with username and password
5. Reload the form
6. Righ-click on the username field -> Fill Login

Expected:
Only the credentials with username should be displayed in the Fill Login context menu -> as it also works in the autocomplete dropdown for username fields

Actual:
The entry with blank username is displayed in the Fill Login context menu.
Selecting that entry will create a blank (highlighted) username field and will toggle the autocomplete dropdown with search results for an existing complete set of credentials

Regression-Range:
Not a regression, can reproduce back to F70

Comment 1

[Matthew N. [:MattN]]

In your video the password field is already filled before using the context menu item… doesn't it still help to fill the password if it was empty? If so, I think the current behaviour isn't a big problem and may be considered a feature.

Comment 2

[Timea Cernea [:tbabos][inactive]]

Not necessarily a big problem, I can imagine it in a scenario where you generate a password for reddit and then go to the Register form.
With Fill Login you can select the blank username of the generated password and just add the email/username to it to register.

However, I am more concerned if there will be any confusion for users if they will see a 'No username" entry in the context menu but will not see it in the autocomplete dropdown for the username field. Placing the autocomplete dropdown and context menu functionality on the same page is what bothers me more here.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:MattN, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Matthew N. [:MattN]]

We discussed with Sandy and we think that we won't do this. If anything, we will do the opposite and add the no username entry to autocomplete.