1614966 - ExtensionXPCShellUtils.jsm overriding of services.settings.default_bucket makes it hard to use remote settings in tests that use add-on manager

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Mark Banner (:standard8)]

ExtensionXPCShellUtils currently overrides services.settings.default_bucket to make it not work for some url formatter tests. This breaks remote settings and makes it hard for remote settings to be used in other places, for example the search service.

https://searchfox.org/mozilla-central/rev/7e92a667e3829831c31e8d46aefe7ef67ad5be1c/toolkit/components/extensions/ExtensionXPCShellUtils.jsm#913

I think preferably it should only be overridden for the tests that really need it, or it should be handled a different way.

In bug 1612416 we are adding a bunch of resets for the preference so that remote settings will work properly for the search service.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

We could move that part into our head.js files and remove them from ExtensionXPCShellUtils.jsm so that other tests can use ExtensionTestUtils without getting that pref always set.

Comment 2

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cca59945cf3a334142655f01b295328981d81b31

Comment 3

[Shane Caraveo (:mixedpuppy)]

It seems like the failures that those settings fixed were limited to toolkit/components/extensions/test/xpcshell, so the change can just apply to those initially.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1614966 disable remote settings in webext xpcom

Move a prior fix from bug 1582053 into the test ini files. This allows other tests that use the test utils to also rely on remote settings working properly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc807514ff49
disable remote settings in webext xpcom r=Ehsan

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cc807514ff49

Comment 7

[Rob Wu [:robwu]]

Adding dependency for visibility. The patch here didn't do anything until bug 1635227 added support for the prefs key in test manifests.