1614985 - [traceback] "JSONDecodeError: Expecting value" in collector

Status: RESOLVED FIXED

(Socorro :: Antenna, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

https://sentry.prod.mozaws.net/operations/socorro-new-prod/issues/7260715/

JSONDecodeError: Expecting value: line 1 column 2233 (char 2232)
  File "raven/middleware.py", line 20, in common_exception_handling
    yield
  File "raven/middleware.py", line 100, in __call__
    iterable = self.application(environ, start_response)
  File "falcon/api.py", line 244, in __call__
    responder(req, resp, **params)
  File "markus/main.py", line 489, in _timer_decorator
    return fun(*args, **kwargs)
  File "antenna/breakpad_resource.py", line 401, in on_post
    raw_crash, dumps = self.extract_payload(req)
  File "antenna/breakpad_resource.py", line 318, in extract_payload
    raw_crash = json.loads(fs_item.value)
  File "json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None

The json.loads code should be wrapped in a try/except to handle errors.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to do now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 446: bug 1614985: handle JSONDecodeError in json value

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #446: "bug 1614985: handle JSONDecodeError in json value" in dfc48f3.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

This went to prod just now in bug #1617958. Marking as FIXED.