Closed
Bug 1614990
Opened 4 years ago
Closed 4 years ago
WebPushController.onSubscriptionChanged should only need the scope
Categories
(GeckoView :: General, defect)
Tracking
(firefox75 fixed)
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: jonalmeida, Assigned: jonalmeida)
References
Details
Attachments
(1 file)
We want to do the same thing as below, but for onSubscriptionChanged.
+++ This bug was initially created as a clone of Bug #1596588 +++
When delivering a message to GeckoView, the scope is the only attribute needed for doing so in the WebPushScription. We should change the API to reflect that since passing the full subscription back for every message is harder to reconstruct and unsafe as well.
From:
onPushEvent(WebPushSubscription subscription)
onPushEvent(WebPushSubscription subscription, byte[] data)
To:
onPushEvent(String scope)
onPushEvent(String scope, byte[] data)
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by jonalmeida942@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b3f0df8ad260 Update WebPushController.onSubscriptionChanged to take only the scope. r=snorp
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•