1614992 - Crash in [@ IPCError-browser | ShutDownKill | mozilla::layers::CompositorBridgeChild::FlushAsyncPaints]

Status: RESOLVED WORKSFORME

(Core :: Graphics: Layers, defect, P3)

Description

[Simon Giesecke [:sg] [he/him]]

This bug is for crash report bp-93e256f2-9e6c-4c53-8ca5-7d2f70200212.

Top 10 frames of crashing thread:

0 ntdll.dll NtWaitForAlertByThreadId 
1 ntdll.dll RtlSleepConditionVariableSRW 
2 kernelbase.dll SleepConditionVariableSRW 
3 mozglue.dll mozilla::detail::ConditionVariableImpl::wait mozglue/misc/ConditionVariable_windows.cpp:50
4 xul.dll mozilla::layers::CompositorBridgeChild::FlushAsyncPaints gfx/layers/ipc/CompositorBridgeChild.cpp:1132
5 xul.dll mozilla::layers::ClientLayerManager::FlushAsyncPaints gfx/layers/client/ClientLayerManager.cpp:486
6 xul.dll mozilla::layers::ClientLayerManager::EndTransactionInternal gfx/layers/client/ClientLayerManager.cpp:309
7 xul.dll mozilla::layers::ClientLayerManager::EndTransaction gfx/layers/client/ClientLayerManager.cpp:415
8 xul.dll nsDisplayList::PaintRoot layout/painting/nsDisplayList.cpp:3130
9 xul.dll static nsLayoutUtils::PaintFrame layout/base/nsLayoutUtils.cpp:4093

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

This seems to happen mostly on nightly, and presumably due to OMTP going AWOL somehow. The release/beta channel volumes are fairly low.

Comment 2

[Gabriele Svelto [:gsvelto]]

Added a few signatures. This happens only on nightly because we don't gather crash reports for content process shutdown kills on beta/release. I've looked into a few of the crashes and in most cases it seems the code is waiting here but there's no activity on any of the other threads in the process, as if it were deadlocked.

Comment 3

[alex_mayorga]

¡Hola!

Per https://crash-stats.mozilla.org/signature/?product=Firefox&signature=IPCError-browser%20%7C%20ShutDownKill%20%7C%20mozilla%3A%3Alayers%3A%3ACompositorBridgeChild%3A%3AFlushAsyncPaints it happens on 74 and 73 as well.

¡Gracias!
Alex

Comment 4

[Gabriele Svelto [:gsvelto]]

I've re-analyzed some of these crashes and it seems that in all of them the content process was processing a refresh driver tick. None of the reports in the last week has the IPCShutdownState annotation set which means that they did not even acknowledge the IPC shutdown message. Most likely the refresh driver tick message was sitting in the queue before the shutdown one and so we never got to process it.

Comment 5

[Gabriele Svelto [:gsvelto]]

Added a macOS-specific signature

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

The OMTP threads seem to be doing real work so this could just be the case of a really long paint.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.