Make CopyableErrorResult safer to use
Categories
(Core :: DOM: Bindings (WebIDL), defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(3 files)
Right now, CopyableErrorResult will cast to ErrorResult&, which means someone could throw a JS exception on it, which is not desirable. We should be able to prevent this.
|
Assignee | |
Comment 1•4 years ago
|
||
We need the explicit constructor because otherwise which conversion operator to
use when constructing an ErrorResult from a CopyableErrorResult&& is
ambiguous. And we want the conversion operator to allow passing
CopyableErrorResult& to functions that expect ErrorResult&&.
|
|
Assignee | |
Comment 2•4 years ago
|
||
The rejection process consumes the ErrorResult, so an rvalue reference is the honest thing here.
|
|
Assignee | |
Comment 3•4 years ago
|
||
This keeps us from passing it to functions that are planning to throw on the
ErrorResult and might throw a JS exception on it.
|
|
Assignee | |
Updated•4 years ago
|
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8592b157cb28 part 1. Allow move-constructing ErrorResult from CopyableErrorResult. r=farre https://hg.mozilla.org/integration/autoland/rev/43951ee85845 part 2. Require an rvalue reference to reject a Promise with an ErrorResult. r=farre,kvark https://hg.mozilla.org/integration/autoland/rev/5d563581134e part 3. Disallow conversion of CopyableErrorResult to ErrorResult&. r=farre
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8592b157cb28
https://hg.mozilla.org/mozilla-central/rev/43951ee85845
https://hg.mozilla.org/mozilla-central/rev/5d563581134e
Description
•