Horizontal alignment issue when select item in Applications Action
Categories
(Firefox :: Settings UI, defect, P5)
Tracking
()
People
(Reporter: alice0775, Assigned: jaws)
References
(Blocks 1 open bug)
Details
(Keywords: polish)
Attachments
(2 files)
screenshot
This is trivial visual issue.
Steps To Reproduce:
- open about:preferences
- Select item in Applications Action
Actual Results:
Icon and text shift to the left
Expected Results:
No shift
I started digging and I see that there are different styles for this across the platforms, with some stylings from preferences.inc.css overriding the same rules from applications.css, so I'm not sure what are the specs for the Applications section.
I found bug 738796 with some specs but that's from 6 years ago, pre-Photon.
mconley, do you happen to have a recent spec on this, or can you needinfo someone who does?
I'd like to work on this, and fix other spacing-related issues there as well.
|
||
Comment 2•4 years ago
|
||
Hm, the closest thing I can find is attachment 8819510 [details] from bug 1324168... jaws, do you remember if there was a more detailed spec somewhere from when the preferences refresh happened?
|
Assignee | |
Comment 3•4 years ago
|
||
There was not a more detailed spec. I looked at the CSS and believe that this patch will fix the alignment.
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 5•4 years ago
|
||
Can someone get manually test the fix works OK on all 3 platforms? Thanks :)
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/224c236a9590 Fix horizontal alignment of icons in the applications handlers list of Preferences. r=preferences-reviewers,ntim
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
||
Comment 8•4 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #5)
Can someone get manually test the fix works OK on all 3 platforms? Thanks :)
Hello!
I've tested the fix with Firefox 84.0a1 (20201115213216) on Windows 10x64, Ubuntu 18.04, macOS 10.12 and 11.0.1:
- On Windows 10x64 the issue appears to be fixed. The text and icons are no longer shifted to the left: screen recording
- On Ubuntu 18.04 the icon is not shifted but the text is shifted upwards: screen recording
- On macOS 10.12 and 11.0.1 the text and the icon is still shifted: screen recording
I don't know if this needs to be reopened to it needs another bug opened to address the remaining issues on macOS and Ubuntu 18.
If more information is needed please let me know. Thanks!
|
|
||
Comment 9•4 years ago
|
||
Hi, thanks for testing!
On Ubuntu 18.04 the icon is not shifted but the text is shifted upwards: screen recording
This can be addressed separately, since it's vertical alignment.
On macOS 10.12 and 11.0.1 the text and the icon is still shifted: screen recording
Hmm, interesting, things look fine on my side with this change. I'm wondering if this has to do with font-size configuration or something else.
I don't know if this needs to be reopened to it needs another bug opened to address the remaining issues on macOS and Ubuntu 18.
Jared, what do you think?
|
|
Assignee | |
Comment 10•4 years ago
|
||
We should open a new bug for the macOS issue. I'm not too concerned about the Ubuntu issue, users may just perceive the slight vertical movement as intentional when the item converts to a menulist. I'd also rather have someone spend time on something with greater impact.
|
||
Updated•4 years ago
|
|
|
||
Comment 11•4 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #10)
We should open a new bug for the macOS issue. I'm not too concerned about the Ubuntu issue, users may just perceive the slight vertical movement as intentional when the item converts to a menulist. I'd also rather have someone spend time on something with greater impact.
Verified again on Windows 10x64 with Firefox 84.0b1(20201116212331). Removing the qe+ flag and closing this as verified based on the above. Thank you!
Description
•