Closed Bug 1615048 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21763 - Update chromium logger to identify subtest failures.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21763 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21763
Details from upstream follow.

Luke Zielinski <lpz@chromium.org> wrote:

Update chromium logger to identify subtest failures.

This also fixes a bug where a subtest failure would be hidden because
the expected_status was evaluated too late in test_end. For a
subtest failure the test status is Pass. But for Chromium, we flip this
"actual" status to a failure.
But the actual status is also used as a fall-back for the expected status
(see explanation in chromium.py:126). So if expected is evaluated after the
"flip", it will just match actual and the failure will be marked as
an "expected" failure.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec2e37b3e918
[wpt PR 21763] - Update chromium logger to identify subtest failures., a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/ec2e37b3e918

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.