Closed Bug 1615082 Opened 6 years ago Closed 6 years ago

Intermittent PID 24189 | Assertion failure: CurrentThreadCanAccessRuntime(thing->runtimeFromAnyThread()) || CurrentThreadCanAccessZone(thing->zoneFromAnyThread()), at /builds/worker/workspace/build/src/js/src/gc/Marking.cpp:3594

Categories

(Core :: JavaScript: GC, defect, P5)

Product:
Core
Component:
JavaScript: GC
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- unaffected
firefox74 --- unaffected
firefox75 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jonco)

References

(Regression)

Details

(Keywords: assertion, intermittent-failure, regression)

Attachments

(1 file)

Bug 1615082 - Fix IsMarked assertions to allow use by off-thread marking during sweeping and make wasm::Instance use IsMarked rather than IsAboutToBeFinalized r?sfink
47 bytes, text/x-phabricator-request
Details | Review

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=288584949&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CkdxbgG3SVa2VaZTg6UNTA/runs/0/artifacts/public/logs/live_backing.log

[task 2020-02-12T21:55:46.257Z] 21:55:46 INFO - TEST-START | /wasm/jsapi/table/grow.any.worker.html
[task 2020-02-12T21:55:46.262Z] 21:55:46 INFO - Closing window 8589934612
[task 2020-02-12T21:55:47.166Z] 21:55:47 INFO - PID 24189 | [Child 24395, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannel, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannel.cpp, line 64
[task 2020-02-12T21:55:48.302Z] 21:55:48 INFO - PID 24189 | Assertion failure: CurrentThreadCanAccessRuntime(thing->runtimeFromAnyThread()) || CurrentThreadCanAccessZone(thing->zoneFromAnyThread()), at /builds/worker/workspace/build/src/js/src/gc/Marking.cpp:3594
[task 2020-02-12T21:55:48.666Z] 21:55:48 INFO - PID 24189 | [Parent 24189, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/workspace/build/src/ipc/glue/ProtocolUtils.cpp, line 481
[task 2020-02-12T21:55:48.674Z] 21:55:48 INFO - PID 24189 | ###!!! [Parent][MessageChannel] Error: (msgtype=0x370136,name=PContent::Msg_DetachBrowsingContext) Channel error: cannot send/recv
[task 2020-02-12T21:55:48.770Z] 21:55:48 INFO - PID 24189 | [Parent 24189, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/workspace/build/src/ipc/glue/ProtocolUtils.cpp, line 481
[task 2020-02-12T21:55:48.770Z] 21:55:48 INFO - PID 24189 | [Parent 24189, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/workspace/build/src/ipc/glue/ProtocolUtils.cpp, line 481
[task 2020-02-12T21:55:48.792Z] 21:55:48 INFO - PID 24189 | [Parent 24189, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ipc/ProtocolUtils.h, line 295
[task 2020-02-12T21:55:48.853Z] 21:55:48 INFO - PID 24189 | A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down
[task 2020-02-12T21:55:49.295Z] 21:55:49 INFO - PID 24189 | JavaScript error: chrome://marionette/content/listener.js, line 378: SecurityError: Permission denied to access property "windowUtils" on cross-origin object
[task 2020-02-12T21:55:49.311Z] 21:55:49 INFO - PID 24189 | [Parent 24189, Main Thread] WARNING: '!inner', file /builds/worker/workspace/build/src/dom/ipc/JSWindowActorService.cpp, line 182
[task 2020-02-12T21:55:49.311Z] 21:55:49 INFO - PID 24189 | [Parent 24189, Main Thread] WARNING: '!inner', file /builds/worker/workspace/build/src/dom/ipc/JSWindowActorService.cpp, line 182
[task 2020-02-12T21:55:49.319Z] 21:55:49 INFO - PID 24189 | [GPU 24237, Compositor] WARNING: Possibly dropping task posted to updater thread: file /builds/worker/workspace/build/src/gfx/layers/apz/src/APZUpdater.cpp, line 429
[task 2020-02-12T21:55:49.343Z] 21:55:49 INFO - PID 24189 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-02-12T21:55:49.384Z] 21:55:49 INFO - PID 24189 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-02-12T21:55:49.386Z] 21:55:49 INFO - PID 24189 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-02-12T21:55:49.461Z] 21:55:49 INFO - PID 24189 | [2020-02-12T21:55:49Z WARN xulstore::persist] tried to remove key that isn't in the store
[task 2020-02-12T21:55:49.463Z] 21:55:49 INFO - PID 24189 | [2020-02-12T21:55:49Z WARN xulstore::persist] tried to remove key that isn't in the store
[task 2020-02-12T21:55:49.499Z] 21:55:49 INFO - Browser not responding, setting status to CRASH
[task 2020-02-12T21:55:49.500Z] 21:55:49 INFO - mozcrash Copy/paste: /builds/worker/fetches/minidump_stackwalk/minidump_stackwalk /tmp/tmpiTYgt0.mozrunner/minidumps/0f44ba77-05fb-4aac-e409-946683040460.dmp /builds/worker/workspace/build/symbols
[task 2020-02-12T21:55:49.527Z] 21:55:49 INFO - PID 24189 | [Parent 24189, Main Thread] WARNING: unable to post continuation event: file /builds/worker/workspace/build/src/xpcom/io/nsStreamUtils.cpp, line 453
[task 2020-02-12T21:55:49.611Z] 21:55:49 INFO - PID 24189 | [Child 24282, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/workspace/build/src/xpcom/base/nsCycleCollector.cpp, line 3362
[task 2020-02-12T21:55:49.653Z] 21:55:49 INFO - PID 24189 | nsStringStats
[task 2020-02-12T21:55:49.654Z] 21:55:49 INFO - PID 24189 | => mAllocCount: 23412
[task 2020-02-12T21:55:49.654Z] 21:55:49 INFO - PID 24189 | => mReallocCount: 0
[task 2020-02-12T21:55:49.654Z] 21:55:49 INFO - PID 24189 | => mFreeCount: 23412
[task 2020-02-12T21:55:49.655Z] 21:55:49 INFO - PID 24189 | => mShareCount: 11860
[task 2020-02-12T21:55:49.655Z] 21:55:49 INFO - PID 24189 | => mAdoptCount: 452
[task 2020-02-12T21:55:49.655Z] 21:55:49 INFO - PID 24189 | => mAdoptFreeCount: 488
[task 2020-02-12T21:55:49.655Z] 21:55:49 INFO - PID 24189 | => Process ID: 24282, Thread ID: 139631231260544
[task 2020-02-12T21:55:49.777Z] 21:55:49 INFO - PID 24189 | [Child 24308, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/workspace/build/src/xpcom/base/nsCycleCollector.cpp, line 3362
[task 2020-02-12T21:55:49.813Z] 21:55:49 INFO - PID 24189 | nsStringStats

[task 2020-02-12T21:55:55.870Z] 21:55:55 INFO - PROCESS-CRASH | /wasm/jsapi/table/grow.any.worker.html | application crashed [@ CheckIsMarkedThing<JSObject*>(JSObject**)]
[task 2020-02-12T21:55:55.870Z] 21:55:55 INFO - Mozilla crash reason: MOZ_ASSERT(CurrentThreadCanAccessRuntime(thing->runtimeFromAnyThread()) || CurrentThreadCanAccessZone(thing->zoneFromAnyThread()))
[task 2020-02-12T21:55:55.871Z] 21:55:55 INFO - Crash dump filename: /tmp/tmpiTYgt0.mozrunner/minidumps/0f44ba77-05fb-4aac-e409-946683040460.dmp
[task 2020-02-12T21:55:55.871Z] 21:55:55 INFO - Operating system: Linux
[task 2020-02-12T21:55:55.872Z] 21:55:55 INFO - 0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64
[task 2020-02-12T21:55:55.872Z] 21:55:55 INFO - CPU: amd64
[task 2020-02-12T21:55:55.872Z] 21:55:55 INFO - family 6 model 62 stepping 4
[task 2020-02-12T21:55:55.872Z] 21:55:55 INFO - 4 CPUs
[task 2020-02-12T21:55:55.873Z] 21:55:55 INFO -
[task 2020-02-12T21:55:55.873Z] 21:55:55 INFO - GPU: UNKNOWN
[task 2020-02-12T21:55:55.873Z] 21:55:55 INFO -
[task 2020-02-12T21:55:55.874Z] 21:55:55 INFO - Crash reason: SIGSEGV /SEGV_MAPERR
[task 2020-02-12T21:55:55.874Z] 21:55:55 INFO - Crash address: 0x0
[task 2020-02-12T21:55:55.875Z] 21:55:55 INFO - Process uptime: not available
[task 2020-02-12T21:55:55.876Z] 21:55:55 INFO -
[task 2020-02-12T21:55:55.876Z] 21:55:55 INFO - Thread 6 (crashed)
[task 2020-02-12T21:55:55.877Z] 21:55:55 INFO - 0 libxul.so!void CheckIsMarkedThing<JSObject*>(JSObject**) [Marking.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 3593 + 0x65]
[task 2020-02-12T21:55:55.877Z] 21:55:55 INFO - rax = 0x00007f847a1a2ef3 rdx = 0x0000000000000000
[task 2020-02-12T21:55:55.877Z] 21:55:55 INFO - rcx = 0x000055b2021f2d88 rbx = 0x00007f846ac18000
[task 2020-02-12T21:55:55.878Z] 21:55:55 INFO - rsi = 0x00007f84857d68b0 rdi = 0x00007f84857d5680
[task 2020-02-12T21:55:55.878Z] 21:55:55 INFO - rbp = 0x00007f846a8ffae0 rsp = 0x00007f846a8ffad0
[task 2020-02-12T21:55:55.878Z] 21:55:55 INFO - r8 = 0x00007f84857d68b0 r9 = 0x00007f846a900700
[task 2020-02-12T21:55:55.878Z] 21:55:55 INFO - r10 = 0x0000000000000000 r11 = 0x0000000000000000
[task 2020-02-12T21:55:55.879Z] 21:55:55 INFO - r12 = 0x00007f846ac207b0 r13 = 0x00007f846ac207b0
[task 2020-02-12T21:55:55.879Z] 21:55:55 INFO - r14 = 0x000036eb7df111c0 r15 = 0x000036eb7df111c0
[task 2020-02-12T21:55:55.879Z] 21:55:55 INFO - rip = 0x00007f847725031f
[task 2020-02-12T21:55:55.879Z] 21:55:55 INFO - Found by: given as instruction pointer in context
[task 2020-02-12T21:55:55.880Z] 21:55:55 INFO - 1 libxul.so!bool js::gc::IsAboutToBeFinalizedInternal<JSObject>(JSObject**) [Marking.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 3661 + 0x8]
[task 2020-02-12T21:55:55.880Z] 21:55:55 INFO - rbx = 0x00007f84679915c8 rbp = 0x00007f846a8ffb10
[task 2020-02-12T21:55:55.880Z] 21:55:55 INFO - rsp = 0x00007f846a8ffaf0 r12 = 0x00007f846ac207b0
[task 2020-02-12T21:55:55.881Z] 21:55:55 INFO - r13 = 0x00007f846ac207b0 r14 = 0x00007f84679915c8
[task 2020-02-12T21:55:55.881Z] 21:55:55 INFO - r15 = 0x000036eb7df111c0 rip = 0x00007f847724e512
[task 2020-02-12T21:55:55.882Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.883Z] 21:55:55 INFO - 2 libxul.so!js::wasm::Instance::tracePrivate(JSTracer*) [WasmInstance.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 1439 + 0xc]
[task 2020-02-12T21:55:55.883Z] 21:55:55 INFO - rbx = 0x00007f84679915c8 rbp = 0x00007f846a8ffb50
[task 2020-02-12T21:55:55.884Z] 21:55:55 INFO - rsp = 0x00007f846a8ffb20 r12 = 0x00007f846ac207b0
[task 2020-02-12T21:55:55.884Z] 21:55:55 INFO - r13 = 0x00007f846ac207b0 r14 = 0x00007f84679915c0
[task 2020-02-12T21:55:55.885Z] 21:55:55 INFO - r15 = 0x000036eb7df111c0 rip = 0x00007f84777a8c60
[task 2020-02-12T21:55:55.885Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.885Z] 21:55:55 INFO - 3 libxul.so!js::GCMarker::processMarkStackTop(js::SliceBudget&) [Marking.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 2009 + 0x90]
[task 2020-02-12T21:55:55.886Z] 21:55:55 INFO - rbx = 0x00007f847b86e478 rbp = 0x00007f846a8ffc00
[task 2020-02-12T21:55:55.886Z] 21:55:55 INFO - rsp = 0x00007f846a8ffb60 r12 = 0x00007f846ac20820
[task 2020-02-12T21:55:55.886Z] 21:55:55 INFO - r13 = 0x00007f846ac207b0 r14 = 0x00007f846ac207c8
[task 2020-02-12T21:55:55.886Z] 21:55:55 INFO - r15 = 0x000036eb7df111c0 rip = 0x00007f8477242d0b
[task 2020-02-12T21:55:55.887Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.887Z] 21:55:55 INFO - 4 libxul.so!js::GCMarker::markUntilBudgetExhausted(js::SliceBudget&) [Marking.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 1804 + 0xb]
[task 2020-02-12T21:55:55.887Z] 21:55:55 INFO - rbx = 0x00007f846ac20820 rbp = 0x00007f846a8ffc90
[task 2020-02-12T21:55:55.888Z] 21:55:55 INFO - rsp = 0x00007f846a8ffc10 r12 = 0x00007f846ac207c8
[task 2020-02-12T21:55:55.888Z] 21:55:55 INFO - r13 = 0x00007f846ac207c8 r14 = 0x00007f846ac207b0
[task 2020-02-12T21:55:55.888Z] 21:55:55 INFO - r15 = 0x00007f846ac213c8 rip = 0x00007f84772437fe
[task 2020-02-12T21:55:55.889Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.889Z] 21:55:55 INFO - 5 libxul.so!js::gc::GCRuntime::markUntilBudgetExhausted(js::SliceBudget&) [GC.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 5438 + 0xb]
[task 2020-02-12T21:55:55.889Z] 21:55:55 INFO - rbx = 0x00007f846ac18000 rbp = 0x00007f846a8ffce0
[task 2020-02-12T21:55:55.890Z] 21:55:55 INFO - rsp = 0x00007f846a8ffca0 r12 = 0x00007f846ac21378
[task 2020-02-12T21:55:55.890Z] 21:55:55 INFO - r13 = 0x0000000000000000 r14 = 0x00007f846ac213c8
[task 2020-02-12T21:55:55.890Z] 21:55:55 INFO - r15 = 0x00007f846ac207b0 rip = 0x00007f84771f4c75
[task 2020-02-12T21:55:55.890Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.891Z] 21:55:55 INFO - 6 libxul.so!js::GCParallelTaskHelper<js::gc::SweepMarkTask>::runTaskTyped(js::GCParallelTask*) [GCParallelTask.h:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 208 + 0xd]
[task 2020-02-12T21:55:55.891Z] 21:55:55 INFO - rbx = 0x00007f846ac21378 rbp = 0x00007f846a8ffd00
[task 2020-02-12T21:55:55.897Z] 21:55:55 INFO - rsp = 0x00007f846a8ffcf0 r12 = 0x00007f846ac21378
[task 2020-02-12T21:55:55.898Z] 21:55:55 INFO - r13 = 0x0000000000000000 r14 = 0x00007f846ac21378
[task 2020-02-12T21:55:55.898Z] 21:55:55 INFO - r15 = 0x00000754d65c5b00 rip = 0x00007f847720d867
[task 2020-02-12T21:55:55.898Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.898Z] 21:55:55 INFO - 7 libxul.so!js::GCParallelTask::runTask() [HelperThreads.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 1837 + 0x7]
[task 2020-02-12T21:55:55.898Z] 21:55:55 INFO - rbx = 0x00007f846ac18000 rbp = 0x00007f846a8ffd40
[task 2020-02-12T21:55:55.898Z] 21:55:55 INFO - rsp = 0x00007f846a8ffd10 r12 = 0x00007f846ac21378
[task 2020-02-12T21:55:55.898Z] 21:55:55 INFO - r13 = 0x0000000000000000 r14 = 0x00007f846ac21378
[task 2020-02-12T21:55:55.898Z] 21:55:55 INFO - r15 = 0x00000754d65c5b00 rip = 0x00007f8476b63dea
[task 2020-02-12T21:55:55.898Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.900Z] 21:55:55 INFO - 8 libxul.so!js::GCParallelTask::runFromHelperThread(js::AutoLockHelperThreadState&) [HelperThreads.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 1822 + 0xa]
[task 2020-02-12T21:55:55.900Z] 21:55:55 INFO - rbx = 0x00007f846ac18000 rbp = 0x00007f846a8ffda0
[task 2020-02-12T21:55:55.900Z] 21:55:55 INFO - rsp = 0x00007f846a8ffd50 r12 = 0x00007f846ac21378
[task 2020-02-12T21:55:55.900Z] 21:55:55 INFO - r13 = 0x0000000000000000 r14 = 0x00007f846ab52000
[task 2020-02-12T21:55:55.900Z] 21:55:55 INFO - r15 = 0x00007f846ac1f000 rip = 0x00007f8476b63b76
[task 2020-02-12T21:55:55.901Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.901Z] 21:55:55 INFO - 9 libxul.so!js::HelperThread::handleGCParallelWorkload(js::AutoLockHelperThreadState&) [HelperThreads.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 1859 + 0x8]
[task 2020-02-12T21:55:55.901Z] 21:55:55 INFO - rbx = 0x0000000000000001 rbp = 0x00007f846a8ffe00
[task 2020-02-12T21:55:55.901Z] 21:55:55 INFO - rsp = 0x00007f846a8ffdb0 r12 = 0x00007f846ac37088
[task 2020-02-12T21:55:55.901Z] 21:55:55 INFO - r13 = 0x0000000000000000 r14 = 0x00007f846a8ffe30
[task 2020-02-12T21:55:55.901Z] 21:55:55 INFO - r15 = 0x00007f846ac37088 rip = 0x00007f8476b642ae
[task 2020-02-12T21:55:55.903Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.903Z] 21:55:55 INFO - 10 libxul.so!js::HelperThread::threadLoop() [HelperThreads.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 2667 + 0x5]
[task 2020-02-12T21:55:55.903Z] 21:55:55 INFO - rbx = 0x00007f847b82e590 rbp = 0x00007f846a8ffe70
[task 2020-02-12T21:55:55.903Z] 21:55:55 INFO - rsp = 0x00007f846a8ffe10 r12 = 0x00007f846ac37088
[task 2020-02-12T21:55:55.904Z] 21:55:55 INFO - r13 = 0x0000000000000000 r14 = 0x00007f846a8ffe30
[task 2020-02-12T21:55:55.904Z] 21:55:55 INFO - r15 = 0x00007f846a8ffe28 rip = 0x00007f8476b662c5
[task 2020-02-12T21:55:55.904Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.904Z] 21:55:55 INFO - 11 libxul.so!js::HelperThread::ThreadMain(void*) [HelperThreads.cpp:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 2189 + 0x8]
[task 2020-02-12T21:55:55.904Z] 21:55:55 INFO - rbx = 0x00007f846ac37088 rbp = 0x00007f846a8ffe90
[task 2020-02-12T21:55:55.905Z] 21:55:55 INFO - rsp = 0x00007f846a8ffe80 r12 = 0x00007f846a8fff80
[task 2020-02-12T21:55:55.905Z] 21:55:55 INFO - r13 = 0x0000000000000000 r14 = 0x00007f846ac380c0
[task 2020-02-12T21:55:55.905Z] 21:55:55 INFO - r15 = 0x00007ffefddcb9c0 rip = 0x00007f8476b5fdb5
[task 2020-02-12T21:55:55.910Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.913Z] 21:55:55 INFO - 12 libxul.so!js::detail::ThreadTrampoline<void (&)(void*), js::HelperThread*>::Start(void*) [Thread.h:584f0d57a0efe35658674d0e8d23f27a11114ae1 : 207 + 0x1a]
[task 2020-02-12T21:55:55.913Z] 21:55:55 INFO - rbx = 0x00007f846ac380b0 rbp = 0x00007f846a8ffeb0
[task 2020-02-12T21:55:55.913Z] 21:55:55 INFO - rsp = 0x00007f846a8ffea0 r12 = 0x00007f846a8fff80
[task 2020-02-12T21:55:55.913Z] 21:55:55 INFO - r13 = 0x0000000000000000 r14 = 0x00007f846ac380c0
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - r15 = 0x00007ffefddcb9c0 rip = 0x00007f8476b73fb4
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - 13 libpthread-2.27.so + 0x76db
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - rbx = 0x0000000000000000 rbp = 0x0000000000000000
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - rsp = 0x00007f846a8ffec0 r12 = 0x00007f846a8fff80
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - r13 = 0x0000000000000000 r14 = 0x00007f846ac380b0
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - r15 = 0x00007ffefddcb9c0 rip = 0x00007f848652c6db
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - Found by: call frame info
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - 14 libc-2.27.so + 0x12188f
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - rsp = 0x00007f846a8fff80 rip = 0x00007f848550a88f
[task 2020-02-12T21:55:55.914Z] 21:55:55 INFO - Found by: stack scanning

It looks like I broke the assertions in CheckIsMarkedThing in bug 1614650.

Assignee: nobody → jcoppeard
Regressed by: 1614650
Has Regression Range: --- → yes
Keywords: regression

I unintentionally changed the assertions in CheckIsMarkedThing to ignore marking (but left the comment intact!).

Also, IsAboutToBeFinalized always returns true during marking so this assertion will always pass. Fixed this by changing to IsMarked, but I had to add back a previouly removed version of IsMarked. I'm not actually sure it's worth it for this assertion, but whatever.

Attachment #9126763 - Attachment description: Bug 1615082 - Fix wasm::Instance marking assertion and assert that IsAboutToBeFinalized is not called on things from other runtimes r?sfink → Bug 1615082 - Fix IsMarked assertions to allow use by off-thread markin during sweeping and make wasm::Instance use IsMarked rather than IsAboutToBeFinalized r?sfink
Attachment #9126763 - Attachment description: Bug 1615082 - Fix IsMarked assertions to allow use by off-thread markin during sweeping and make wasm::Instance use IsMarked rather than IsAboutToBeFinalized r?sfink → Bug 1615082 - Fix IsMarked assertions to allow use by off-thread marking during sweeping and make wasm::Instance use IsMarked rather than IsAboutToBeFinalized r?sfink
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/276d33ec47fa Fix IsMarked assertions to allow use by off-thread marking during sweeping and make wasm::Instance use IsMarked rather than IsAboutToBeFinalized r=sfink
Backout by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2517f89debb1 Backed out changeset 276d33ec47fa For spidermonkey failure on workspace/build/src/js/src/wasm/WasmInstance.cpp. CLOSED TREE
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e642e16d2b5 Fix IsMarked assertions to allow use by off-thread marking during sweeping and make wasm::Instance use IsMarked rather than IsAboutToBeFinalized r=sfink

https://hg.mozilla.org/mozilla-central/rev/4e642e16d2b5

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: