1615142 - In textarea or pre element, triple-click to select line selects next line too

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect, P2)

Description

[Sebastian Simon]

Attachment: Demo.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

A day or two ago, I triple-clicked text in a textarea to select an entire line (out of many). Alternatively, try to select a single line in the middle of a multi-line <pre> element (or a <div> with white-space: pre;, but not a <div> with <br>s for line separation) using triple-click.

I was using Firefox Nightly 74 (right before the 75 update).

Actual results:

The triple-clicked line got selected, but also the line after it. The video shows a demo of what happens. Curiously, it doesn’t happen if I triple-click a line before a link contained in that line.

Expected results:

Only the intended triple-clicked line should be selected.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=db2720efb1a5957d71bdcf73dc40fcd4f922394a&tochange=476a32323adb592141a7e1f63df5cbe0518e6344

Regressed by Bug 1603964

Comment 2

[Alice0775 White]

Attachment: html

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]: ux broken

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Thanks for reporting :)

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Oh and of course thanks alice for finding the regression range :)

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1615142 - Fix triple-click selection on pre-formatted text. r=mats

We need to check for terminal new-lines on ourselves before looking at our next
sibling frame.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3734a1392aea
Fix triple-click selection on pre-formatted text. r=mats

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9126454 [details]
Bug 1615142 - Fix triple-click selection on pre-formatted text. r=mats

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0 or the attached HTML.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple fix. Alternative is backing out regressing bug (no huge deal either, but a bit unfortunate)
• String changes made/needed: none

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6ba4726dfba
Fix gcc builds that error because of an unused variable.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3734a1392aea
https://hg.mozilla.org/mozilla-central/rev/b6ba4726dfba

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

As it just landed, I'd like to see it verified by QA on nightly before uplifting to beta.

Comment 13

[Peter Magyari (Desktop QA)]

Reproduced the issue on Firefox 75.0a1 (20200220093508) and on Firefox Beta 74.0b7(20200221211950)
Verified fixed on Firefox Nightly 75.0a1(20200223214228)

Comment 14

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9126454 [details]
Bug 1615142 - Fix triple-click selection on pre-formatted text. r=mats

Covered by tests, fixes a new 74 regression, fix verified by QA on nightly, looks safe enough, uplift approved for 74.0b8, thanks.

Comment 15

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/52984f3709c3
https://hg.mozilla.org/releases/mozilla-beta/rev/131b229c027b

Comment 16

[Peter Magyari (Desktop QA)]

Verified fixed on Firefox Beta 74.0b8 (20200226031638)