1615209 - Fluent migrations should only apply localized entities from bilingual files

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: Fluent Migration, defect, P1)

Description

[Axel Hecht [:Pike]]

When migrating off of .lang files (but also PO), the locale files have entities which are not localized.

Right now, we add them to our legacy translations, which creates all-English Fluent files for non-translated content.

Hit us with mission.ftl on bedrock.

Comment 1

[Axel Hecht [:Pike]]

Attachment: Bug 1615209, check for .localized when reading legacy files, r=stas

For bilingual files, entities exist regardless if they're
localized or not. That's what .localized on Entity represents.

Make sure we use that when reading legacy files, so that we
only migrate content that's actually translated.

And yes, message keys in our gettext implementation are weird,
I haven't yet figured out a better way to support contexts.

Comment 2

[Axel Hecht [:Pike]]

Landed as https://hg.mozilla.org/l10n/fluent-migration/rev/7da7b5442526e0c1de372799f5433dec0ee0fd1d.