Closed Bug 1615220 Opened 5 years ago Closed 5 years ago

Generate Password context menu option does not toggle the autocomplete dropdown if Master Password auth dialog was canceled on a form with saved credentials

Categories

(Toolkit :: Password Manager, defect, P2)

Product:
Toolkit
Component:
Password Manager
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- unaffected
firefox74 --- verified
firefox75 --- verified

People

(Reporter: tbabos, Assigned: MattN)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [passwords:generation] [passwords:master-password])

Attachments

(3 files)

Expected 1. No credentials saved
240.79 KB, video/mp4
Details
Actual result - Credentials saved
484.10 KB, video/mp4
Details
Bug 1615220 - Disable password generation when master password is locked. r=jaws,sfoster
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

Affected platforms:
Windows 10 x64

Affected versions:
Nightly 75
Beta 74

Unaffected version:
Release 73 -> The "Use Generated Password" is in the "Fill Password" submenu, which is grayed out if Master Password prompt is dismissed.

Steps to reproduce:

  1. Set up Master Password on a Firefox Profile
  2. Save 1 set of credentials on any form (important)
  3. Restart the browser
  4. Reach the previously opened login form
  5. Dismiss the Master Password auth with "x" or "cancel"
  6. Right-click on the Password field-> Use Generated Password

Expected:

  1. The autocomplete dropdown should be displayed only with the Password Generation option-> this is how it works if there are no saved credentials on the form and toggle the master password prompt again after generating
  2. Gray out the "Use Generated Password" option in the context menu if MP is dismissed on a site with saved credentials

Actual:
The autocomplete dropdown is either not toggled or only the "View Saved Logins" footer is displayed

Regression-Range:
This happens due to the changes made via Bug 1595915 which moved the "Use Generated Password" option to the main context menu instead of the submenu. Without these changes, the users can't access password generation without the MP.

Great find

Has Regression Range: --- → yes
Has STR: --- → yes
Priority: -- → P2
Whiteboard: [passwords:generation] [passwords:master-password]

:MattN, is there someone that can work on this issue (tracked as regression for FF74 and 75) ?

Flags: needinfo?(MattN+bmo)

This aligns with the behaviour before bug 1595915 since password generation was nested under the disabled "Fill (username|password)" option.

Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(MattN+bmo)
Attachment #9129211 - Attachment description: Bug 1615220 - Disable password generation when is master password is locked. r=jaws,sfoster → Bug 1615220 - Disable password generation when master password is locked. r=jaws,sfoster
Flags: qe-verify+

Comment on attachment 9129211 [details]
Bug 1615220 - Disable password generation when master password is locked. r=jaws,sfoster

Beta/Release Uplift Approval Request

  • User impact if declined: If the user cancels master password entry, they will have a non-functional password generation context menu item
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Added a trivial check that MP is unlocked to align with the previous behaviour when the menu item was in a submenu that did that check.
  • String changes made/needed: None
Attachment #9129211 - Flags: approval-mozilla-beta?
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/fbc90d35117e Disable password generation when master password is locked. r=jaws

Backed out changeset fbc90d35117e (Bug 1615220) for browser_autocomplete_generated_password_private_window.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&fromchange=90f3b7ce319f38f1df583574f9f926d1d98a28f0&tochange=5fc409bc353096febfdcbbc09d788c6d3944ac47&selectedJob=290632648

Backout link: https://hg.mozilla.org/integration/autoland/rev/bc9bb01f985a2c91c4dc07381997720d56fddd0e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290632648&repo=autoland&lineNumber=18321

[task 2020-02-26T19:54:47.679Z] 19:54:47     INFO - TEST-START | toolkit/components/passwordmgr/test/browser/browser_autocomplete_generated_password_private_window.js
[task 2020-02-26T19:54:47.734Z] 19:54:47     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x12a6f3800 == 6 [pid = 2100] [id = {413e8c96-9ba5-7147-9e36-37d1d3a43e87}]
[task 2020-02-26T19:54:47.734Z] 19:54:47     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 11 (0x11ab808c0) [pid = 2100] [serial = 11] [outer = 0x0]
[task 2020-02-26T19:54:47.735Z] 19:54:47     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 12 (0x120f0b800) [pid = 2100] [serial = 12] [outer = 0x11ab808c0]
[task 2020-02-26T19:54:48.041Z] 19:54:48     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x136060000 == 7 [pid = 2100] [id = {80bd1bab-543c-c34a-96f1-b83e2c4d296c}]
[task 2020-02-26T19:54:48.041Z] 19:54:48     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 13 (0x132ada430) [pid = 2100] [serial = 13] [outer = 0x0]
[task 2020-02-26T19:54:48.141Z] 19:54:48     INFO - GECKO(2100) | [Child 2103: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x11246a800 == 2 [pid = 2103] [id = {2e368865-8e50-1b4c-b3d9-a3dee6025cb2}]
[task 2020-02-26T19:54:48.141Z] 19:54:48     INFO - GECKO(2100) | [Child 2103: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x14836ade0) [pid = 2103] [serial = 3] [outer = 0x0]
[task 2020-02-26T19:54:48.141Z] 19:54:48     INFO - GECKO(2100) | [Child 2103, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 848
[task 2020-02-26T19:54:48.142Z] 19:54:48     INFO - GECKO(2100) | [Child 2103: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x14833f400) [pid = 2103] [serial = 4] [outer = 0x14836ade0]
[task 2020-02-26T19:54:48.193Z] 19:54:48     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 14 (0x132aa9800) [pid = 2100] [serial = 14] [outer = 0x132ada430]
[task 2020-02-26T19:54:48.373Z] 19:54:48     INFO - GECKO(2100) | [Child 2103: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x148344000) [pid = 2103] [serial = 5] [outer = 0x14836ade0]
[task 2020-02-26T19:54:48.424Z] 19:54:48     INFO - GECKO(2100) | [Parent 2100, Main Thread] WARNING: Ignoring duplicate observer.: file /builds/worker/workspace/build/src/modules/libpref/Preferences.cpp, line 2692
[task 2020-02-26T19:54:48.476Z] 19:54:48     INFO - GECKO(2100) | [Child 2103, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1393
[task 2020-02-26T19:54:48.477Z] 19:54:48     INFO - GECKO(2100) | [Child 2103, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1393
[task 2020-02-26T19:54:48.673Z] 19:54:48     INFO - GECKO(2100) | [Child 2105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x120e68000 == 2 [pid = 2105] [id = {50432aca-91c2-7c4b-8641-b003b2f2e484}]
[task 2020-02-26T19:54:48.673Z] 19:54:48     INFO - GECKO(2100) | [Child 2105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x1226e5d40) [pid = 2105] [serial = 4] [outer = 0x0]
[task 2020-02-26T19:54:48.673Z] 19:54:48     INFO - GECKO(2100) | [Child 2105, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 848
[task 2020-02-26T19:54:48.673Z] 19:54:48     INFO - GECKO(2100) | [Child 2105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x1228c8c00) [pid = 2105] [serial = 5] [outer = 0x1226e5d40]
[task 2020-02-26T19:54:48.927Z] 19:54:48     INFO - GECKO(2100) | [Child 2106: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x124959000 == 2 [pid = 2106] [id = {1da1b320-d972-c349-adbb-260bf44dcdc0}]
[task 2020-02-26T19:54:48.927Z] 19:54:48     INFO - GECKO(2100) | [Child 2106: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x116f40f60) [pid = 2106] [serial = 3] [outer = 0x0]
[task 2020-02-26T19:54:48.927Z] 19:54:48     INFO - GECKO(2100) | [Child 2106, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 848
[task 2020-02-26T19:54:48.927Z] 19:54:48     INFO - GECKO(2100) | [Child 2106: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x124915000) [pid = 2106] [serial = 4] [outer = 0x116f40f60]
[task 2020-02-26T19:54:48.927Z] 19:54:48     INFO - GECKO(2100) | [Child 2106: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x1249d1000) [pid = 2106] [serial = 5] [outer = 0x116f40f60]
[task 2020-02-26T19:54:49.052Z] 19:54:49     INFO - GECKO(2100) | [Child 2106, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1393
[task 2020-02-26T19:54:49.052Z] 19:54:49     INFO - GECKO(2100) | [Child 2106, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1393
[task 2020-02-26T19:54:49.252Z] 19:54:49     INFO - GECKO(2100) | [Child 2103: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x110469000 == 1 [pid = 2103] [id = {17f4ed7b-bab4-2d42-85c4-0dbc7c709d42}] [url = about:blank]
[task 2020-02-26T19:54:49.341Z] 19:54:49     INFO - GECKO(2100) | [Child 2105, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannel, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannel.cpp, line 64
[task 2020-02-26T19:54:49.341Z] 19:54:49     INFO - GECKO(2100) | [Child 2105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (0x1228a8400) [pid = 2105] [serial = 6] [outer = 0x1226e5d40]
[task 2020-02-26T19:54:49.521Z] 19:54:49     INFO - GECKO(2100) | [Child 2107: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x11d609000 == 1 [pid = 2107] [id = {fdfbc600-363f-7744-8646-53d15d17b139}] [url = https://example.org/document-builder.sjs?html=%3Chtml%3E%3Cbody%3EHi%3C/body%3E%3C/html%3E]
[task 2020-02-26T19:54:49.521Z] 19:54:49     INFO - GECKO(2100) | [Child 2107: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x106db2000 == 0 [pid = 2107] [id = {d2eca23a-0eb1-a442-98e8-2dd0f8ca1a88}] [url = https://example.org/browser/toolkit/components/passwordmgr/test/browser/form_autofocus_frame.html]
[task 2020-02-26T19:54:49.522Z] 19:54:49     INFO - GECKO(2100) | [Child 2101: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (0x10e6b9c00) [pid = 2101] [serial = 2] [outer = 0x0] [url = about:blank]
[task 2020-02-26T19:54:49.522Z] 19:54:49     INFO - GECKO(2100) | [Child 2101: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (0x11a8bf400) [pid = 2101] [serial = 10] [outer = 0x0] [url = about:blank]
[task 2020-02-26T19:54:49.522Z] 19:54:49     INFO - GECKO(2100) | [Child 2101: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (0x10e6bc000) [pid = 2101] [serial = 4] [outer = 0x0] [url = about:blank]
[task 2020-02-26T19:54:49.522Z] 19:54:49     INFO - GECKO(2100) | [Child 2101: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (0x11a8ba400) [pid = 2101] [serial = 6] [outer = 0x0] [url = about:blank]
[task 2020-02-26T19:54:49.522Z] 19:54:49     INFO - GECKO(2100) | [Child 2101: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x11a8bc800) [pid = 2101] [serial = 8] [outer = 0x0] [url = about:blank]
[task 2020-02-26T19:54:49.552Z] 19:54:49     INFO - GECKO(2100) | [Child 2107: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x11d696600) [pid = 2107] [serial = 4] [outer = 0x0] [url = https://example.org/document-builder.sjs?html=%3Chtml%3E%3Cbody%3EHi%3C/body%3E%3C/html%3E]
[task 2020-02-26T19:54:49.786Z] 19:54:49     INFO - GECKO(2100) | [Child 2101: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x11a84a000 == 4 [pid = 2101] [id = {32d5530b-44a8-3340-b05c-499e283ef624}] [url = moz-extension://7d7d3ebd-c143-7343-b883-c6a76b8a04cb/_generated_background_page.html]
[task 2020-02-26T19:54:49.786Z] 19:54:49     INFO - GECKO(2100) | [Child 2101: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x10c00bc60) [pid = 2101] [serial = 3] [outer = 0x0] [url = moz-extension://7d7d3ebd-c143-7343-b883-c6a76b8a04cb/_generated_background_page.html]
[task 2020-02-26T19:54:50.054Z] 19:54:50     INFO - GECKO(2100) | [Child 2105: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x1131c1800 == 1 [pid = 2105] [id = {234a00d2-7765-2547-a960-48a221fa10e4}] [url = data:text/html;charset=utf-8,<html><body><form id='form1'><input id='input2'></form><form id='form2'></form></body></html>]
[task 2020-02-26T19:54:50.153Z] 19:54:50     INFO - GECKO(2100) | [Child 2105, Main Thread] WARNING: SendNotifyIMEFocus got rejected.: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 793
[task 2020-02-26T19:54:50.299Z] 19:54:50     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x12a6f5000 == 8 [pid = 2100] [id = {c962937b-f7e6-d64c-9117-0be0d70b4f74}]
[task 2020-02-26T19:54:50.299Z] 19:54:50     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (0x132ada7d0) [pid = 2100] [serial = 15] [outer = 0x0]
[task 2020-02-26T19:54:50.299Z] 19:54:50     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (0x121abd800) [pid = 2100] [serial = 16] [outer = 0x132ada7d0]
[task 2020-02-26T19:54:50.555Z] 19:54:50     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x1360d2800 == 9 [pid = 2100] [id = {813fa59f-e280-4945-99eb-4be12636e82e}]
[task 2020-02-26T19:54:50.555Z] 19:54:50     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 17 (0x132ada9a0) [pid = 2100] [serial = 17] [outer = 0x0]
[task 2020-02-26T19:54:50.687Z] 19:54:50     INFO - GECKO(2100) | [Child 2103: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x11246b000 == 2 [pid = 2103] [id = {9f2c432e-177d-8241-8cf7-839f9bc2a3ff}]
[task 2020-02-26T19:54:50.687Z] 19:54:50     INFO - GECKO(2100) | [Child 2103: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (0x14bb7f2b0) [pid = 2103] [serial = 6] [outer = 0x0]
[task 2020-02-26T19:54:50.688Z] 19:54:50     INFO - GECKO(2100) | [Child 2103: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (0x12a3c7000) [pid = 2103] [serial = 7] [outer = 0x14bb7f2b0]
[task 2020-02-26T19:54:50.742Z] 19:54:50     INFO - GECKO(2100) | [Parent 2100: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 18 (0x121ac2c00) [pid = 2100] [serial = 18] [outer = 0x132ada9a0]
[task 2020-02-26T19:54:51.002Z] 19:54:51     INFO - GECKO(2100) | [Child 2103: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (0x14b63e800) [pid = 2103] [serial = 8] [outer = 0x14bb7f2b0]
[task 2020-02-26T19:54:51.039Z] 19:54:51     INFO - GECKO(2100) | [Child 2106: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x117272000 == 1 [pid = 2106] [id = {7e769b63-9447-1e43-8ecc-a6f2f1c2298c}] [url = about:blank]
[task 2020-02-26T19:54:51.039Z] 19:54:51     INFO - GECKO(2100) | [Parent 2100, Main Thread] WARNING: Ignoring duplicate observer.: file /builds/worker/workspace/build/src/modules/libpref/Preferences.cpp, line 2692
[task 2020-02-26T19:54:51.254Z] 19:54:51     INFO - GECKO(2100) | [Child 2105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x120e69000 == 2 [pid = 2105] [id = {ce20dd77-bccc-b94b-b302-9093398dfb58}]
[task 2020-02-26T19:54:51.254Z] 19:54:51     INFO - GECKO(2100) | [Child 2105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (0x1226e60e0) [pid = 2105] [serial = 7] [outer = 0x0]
[task 2020-02-26T19:54:51.254Z] 19:54:51     INFO - GECKO(2100) | [Child 2105, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 848
[task 2020-02-26T19:54:51.254Z] 19:54:51     INFO - GECKO(2100) | [Child 2105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (0x120ebf800) [pid = 2105] [serial = 8] [outer = 0x1226e60e0]
[task 2020-02-26T19:54:51.495Z] 19:54:51     INFO - GECKO(2100) | [Child 2106: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x124952000 == 2 [pid = 2106] [id = {bab3f174-082f-f849-9fa9-98349fcff1a2}]
[task 2020-02-26T19:54:51.495Z] 19:54:51     INFO - GECKO(2100) | [Child 2106: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (0x1488dff10) [pid = 2106] [serial = 6] [outer = 0x0]
[task 2020-02-26T19:54:51.495Z] 19:54:51     INFO - GECKO(2100) | [Child 2106: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (0x11722e800) [pid = 2106] [serial = 7] [outer = 0x1488dff10]
[task 2020-02-26T19:54:51.535Z] 19:54:51     INFO - GECKO(2100) | [Child 2106: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (0x1249da800) [pid = 2106] [serial = 8] [outer = 0x1488dff10]
[task 2020-02-26T19:54:51.680Z] 19:54:51     INFO - GECKO(2100) | [Child 2102: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x118110c00) [pid = 2102] [serial = 3] [outer = 0x0] [url = about:blank]
[task 2020-02-26T19:54:51.682Z] 19:54:51     INFO - GECKO(2100) | [Child 2102: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x11837a800) [pid = 2102] [serial = 4] [outer = 0x0] [url = about:blank]
[task 2020-02-26T19:54:51.723Z] 19:54:51     INFO - GECKO(2100) | [Child 2105, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannel, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannel.cpp, line 64
[task 2020-02-26T19:54:51.723Z] 19:54:51     INFO - GECKO(2100) | [Child 2105: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 9 (0x1229b6800) [pid = 2105] [serial = 9] [outer = 0x1226e60e0]
[task 2020-02-26T19:54:51.755Z] 19:54:51     INFO - GECKO(2100) | [Child 2109: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x117eb3800 == 0 [pid = 2109] [id = {66990c00-07c9-0a43-87ca-aba6d38dad6f}] [url = https://example.com/browser/toolkit/components/passwordmgr/test/browser/form_basic.html]
[task 2020-02-26T19:54:52.707Z] 19:54:52     INFO - GECKO(2100) | [Child 2104: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x1251aa800) [pid = 2104] [serial = 5] [outer = 0x0] [url = about:blank]
[task 2020-02-26T19:54:52.707Z] 19:54:52     INFO - GECKO(2100) | [Child 2104: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x126705400) [pid = 2104] [serial = 6] [outer = 0x0] [url = about:logins?filter=example.com&entryPoint=autocomplete]
[task 2020-02-26T19:54:52.707Z] 19:54:52     INFO - GECKO(2100) | [Child 2104: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0x112715c00) [pid = 2104] [serial = 2] [outer = 0x0] [url = about:blank]
[task 2020-02-26T19:54:52.812Z] 19:54:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-26T19:54:52.812Z] 19:54:52     INFO - Buffered messages logged at 19:54:47
[task 2020-02-26T19:54:52.812Z] 19:54:52     INFO - Entering test bound common_initialize
[task 2020-02-26T19:54:52.812Z] 19:54:52     INFO - Leaving test bound common_initialize
[task 2020-02-26T19:54:52.812Z] 19:54:52     INFO - Entering test bound test_autocomplete_new_password_popup_item_visible
[task 2020-02-26T19:54:52.813Z] 19:54:52     INFO - Buffered messages logged at 19:54:48
[task 2020-02-26T19:54:52.813Z] 19:54:52     INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2020-02-26T19:54:52.813Z] 19:54:52     INFO - Version: 2.1 INTEL-12.9.22
[task 2020-02-26T19:54:52.813Z] 19:54:52     INFO - Vendor: Intel Inc.
[task 2020-02-26T19:54:52.813Z] 19:54:52     INFO - Renderer: Intel Iris OpenGL Engine
[task 2020-02-26T19:54:52.813Z] 19:54:52     INFO - FBO Texture Target: TEXTURE_2D
[task 2020-02-26T19:54:52.816Z] 19:54:52     INFO - Buffered messages logged at 19:54:49
[task 2020-02-26T19:54:52.816Z] 19:54:52     INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_autocomplete_generated_password_private_window.js | Got popup - 
[task 2020-02-26T19:54:52.816Z] 19:54:52     INFO - content window focused
[task 2020-02-26T19:54:52.816Z] 19:54:52     INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_autocomplete_generated_password_private_window.js | autocomplete popup shown - 
[task 2020-02-26T19:54:52.816Z] 19:54:52     INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_autocomplete_generated_password_private_window.js | Should get 'Generate password' richlistitem - 
[task 2020-02-26T19:54:52.816Z] 19:54:52     INFO - Buffered messages logged at 19:54:50
[task 2020-02-26T19:54:52.816Z] 19:54:52     INFO - Leaving test bound test_autocomplete_new_password_popup_item_visible
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - Entering test bound test_autocomplete_menu_item_enabled
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - Version: 2.1 INTEL-12.9.22
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - Vendor: Intel Inc.
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - Renderer: Intel Iris OpenGL Engine
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - FBO Texture Target: TEXTURE_2D
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - Buffered messages finished
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_autocomplete_generated_password_private_window.js | Generate password context menu item should be enabled in PB mode - Got true, expected false
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - Stack trace:
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_autocomplete_generated_password_private_window.js:test_autocomplete_menu_item_enabled/<:60
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:150
[task 2020-02-26T19:54:52.817Z] 19:54:52     INFO - chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_autocomplete_generated_password_private_window.js:test_autocomplete_menu_item_enabled:49
[task 2020-02-26T19:54:52.818Z] 19:54:52     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-26T19:54:52.818Z] 19:54:52     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-26T19:54:52.818Z] 19:54:52     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-26T19:54:52.818Z] 19:54:52     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:914
[task 2020-02-26T19:54:52.890Z] 19:54:52     INFO - GECKO(2100) | [Child 2105, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/workspace/build/src/editor/composer/nsEditingSession.cpp, line 1182
[task 2020-02-26T19:54:52.890Z] 19:54:52     INFO - GECKO(2100) | [Child 2105, Main Thread] WARNING: SendNotifyIMEFocus got rejected.: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 793
[task 2020-02-26T19:54:52.939Z] 19:54:52     INFO - GECKO(2100) | [Child 2104: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x1266477d0) [pid = 2104] [serial = 4] [outer = 0x0] [url = about:logins?filter=example.com]
[task 2020-02-26T19:54:52.939Z] 19:54:52     INFO - GECKO(2100) | [Child 2104: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x126689000 == 2 [pid = 2104] [id = {11f15638-6948-e945-b9ba-ee03e5d43ae9}] [url = about:logins?filter=example.com]
[task 2020-02-26T19:54:53.015Z] 19:54:53     INFO - Leaving test bound test_autocomplete_menu_item_enabled
[task 2020-02-26T19:54:53.041Z] 19:54:53     INFO - GECKO(2100) | MEMORY STAT | vsize 7682MB | residentFast 378MB | heapAllocated 160MB
[task 2020-02-26T19:54:53.041Z] 19:54:53     INFO - TEST-OK | toolkit/components/passwordmgr/test/browser/browser_autocomplete_generated_password_private_window.js | took 5353ms
Flags: needinfo?(MattN+bmo)
QA Whiteboard: [qa-triaged]

FYI, I am not taking the uplift at the moment because of the backout. We have shipped our last beta before RC also.

Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/b00d62dfe05c Disable password generation when master password is locked. r=jaws

Unfortunately the test was incorrect.

Flags: needinfo?(MattN+bmo)

https://hg.mozilla.org/mozilla-central/rev/b00d62dfe05c

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75

Comment on attachment 9129211 [details]
Bug 1615220 - Disable password generation when master password is locked. r=jaws,sfoster

Approved for beta before the merge tha

Attachment #9129211 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified-fixed on latest Firefox Nightly 75.0a1 (2020-03-01) (64-bit) on Windows 10 x64, MacOS 10.15 and Ubuntu 18.04.
Password Generation option is disabled if the MP prompt is dismissed.
Waiting for Uplift to Beta.

status-firefox75: fixed → verified

Verified - Fixed on Firefox RC 74.0 (Build ID: 20200302184608) on Windows 10, MacOS 10.14 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
status-firefox74: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: