Open Bug 1615316 Opened 4 years ago Updated 1 month ago

Library - Can't create a new folder if places.xhtml is open in content

Categories

(Firefox :: Bookmarks & History, defect, P5)

75 Branch
defect

Tracking

()

REOPENED

People

(Reporter: krzysztof.glebowicz, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

  1. open the Library,
  2. select any folder in the sidebar,
  3. right mouse click "New folder" in the bookmarks panel,
  4. nothing happens or only an empty dialog box is showing up.

There's a SUMO report about this issue: https://support.mozilla.org/questions/1279599#answer-1289597 and I can confirm it on Nightly.

I captured a video of this issue, if you need it.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Bookmarks & History

From the support site it looks like you're loading the library by typing chrome://browser/content/places/places.xhtml in the address bar.

Although it has generally worked, we've never actually supported it opening in that manner. You need to use the Library -> Bookmarks -> "Show All Bookmarks" action to open it properly.

We have bug 697359 open for rewriting the library / making it work properly in a tab.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX

Mark, the way you open the Library doesn't make any difference. It can be the Library window, tab or menu. We just can't create a new folder. Please reopen this bug, if it's the only reason of wontfix it.

I've experienced the bug with locked bookmarks after manipulating them through the bookmarks toolbar as well.... It all might be interrelated somehow

And, once the bookmarks get locked in the tab, they get locked everywhere

Attached video new-folder-issue.avi

Please can you try this after restarting Firefox without having chrome://browser/content/places/places.xhtml opened? I've just been trying it, and I see some strange effects when that has been open but it is fine when it hasn't been opened.

Status: RESOLVED → REOPENED
Ever confirmed: true
Flags: needinfo?(krzysztof.glebowicz)
Resolution: WONTFIX → ---

The same for me. No issue after restarting and not going to places.xhtml.

Flags: needinfo?(krzysztof.glebowicz)

Codeshark: Is this still an issue for you if you don't open places.xhtml?

Flags: needinfo?(codeshark)

(In reply to Mark Banner (:standard8) from comment #9)

Codeshark: Is this still an issue for you if you don't open places.xhtml?

No, now that I don't have places.xhtml open in a tab, I don't get any problems managing my library/bookmarks..
However, as it happened to me in the recent past, managing the bookmarks via the bookmarks toolbar still used to produce the bug with locked library lot of times, somewhere down the line of Firefox being on for a few hours, after a good deal of browsing, tab opening and bookmark manipulating. So if the bug is still there I probably won't be able to get to it at the moment just like that.
But anyway is there a chance Mozilla could fix that places.xhtml method? Or make it possible to open the library in a tab some other way?

Flags: needinfo?(codeshark)

Do you see errors reported in the Browser Console when you try adding the new folder?
I suspect there's something with the conversion to xhtml and fluent that broke this case, we'd accept a patch from the community to fix the problem, but atm having the library in content is not a priority and thus we don't have the resources to investigate this.
Most of the code is in browser/components/places if someone wants to debug it.

There is a long term plan to provide an in-content UI, but resourcing it is complicate, thus we can't give an ETA on that.

Priority: -- → P5
Summary: Library - Can't create a new folder → Library - Can't create a new folder if places.xhtml is open in content

Do you see errors reported in the Browser Console when you try adding the new folder?

Console error:

[Exception... "Illegal value"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource:///modules/PlacesUIUtils.jsm :: showBookmarkDialog :: line 332"  data: no] PlacesUIUtils.jsm:332:21
showBookmarkDialog resource:///modules/PlacesUIUtils.jsm:332
newItem chrome://browser/content/places/controller.js:730
PC_doCommand chrome://browser/content/places/controller.js:310
doCommand resource:///modules/PlacesUIUtils.jsm:526
oncommand chrome://browser/content/places/places.xhtml:1

Highlighted code:

if (aParentWindow.gDialogBox) {
  await aParentWindow.gDialogBox.open(dialogURL, aInfo);
} else {
  aParentWindow.openDialog(dialogURL, "", features, aInfo);
}
Severity: normal → S3
Attachment #9383265 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: