1615342 - Vertex attribute not found warnings at WebRender startup

Status: RESOLVED INCOMPLETE

(Core :: Graphics: WebRender, defect, P3)

Description

[Miko Mynttinen]

Since this warning was added in bug 1609136, I am getting the following warnings on my terminal when starting Firefox with WebRender enabled (Linux laptop).

[2020-02-13T16:38:41Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipTileRect", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 4, found at -1
[2020-02-13T16:38:41Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipTileRect", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 4, found at -1
[2020-02-13T16:38:41Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipLocalPos", count: 2, kind: F32 } is not found in the shader cs_clip_box_shadow. Expected at 3, found at -1
[2020-02-13T16:38:41Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipTileRect", count: 4, kind: F32 } is not found in the shader cs_clip_box_shadow. Expected at 4, found at -1

Comment 1

[Dzmitry Malyshau [:kvark]]

It's a soft check in debug only. We can't fully get rid of false positives here, see https://searchfox.org/mozilla-central/rev/df94cd5ba431234bc220ac081def0801fe44b89e/gfx/wr/webrender/src/device/gl.rs#1981

I don't think there is anything that should be done about this. The idea is that if you are changing the vertex attributes and you screw up, you'll at least see the new error messages, which may force you to double-check if your code is right.

Comment 4

[Glenn Watson [:gw]]

These got removed.