Closed Bug 1615384 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21784 - Revert "[Layout] SetNeedsLayout when an flex-item image loads"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21784 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21784
Details from upstream follow.

Stephen McGruer <smcgruer@chromium.org> wrote:

Revert "[Layout] SetNeedsLayout when an flex-item image loads"

This reverts commit 8495f49a06325e133bdf7852aaf83f52700209a1.

Reason for revert: Suspected of causing failure in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-003v.html on multiple builders, https://crbug.com/1052029

Original change's description:

[Layout] SetNeedsLayout when an flex-item image loads

Flex layout incorporates an image's intrinsic size even when it has a
specified height and width.

Bug: 1042329
Change-Id: I206ba12a07103b4b90c364fb19b70b8ba2784d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050821
Commit-Queue: David Grogan \<dgrogan@chromium.org>
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#741091}

TBR=dgrogan@chromium.org,fs@opera.com

Change-Id: I7dbc00b05f9a14b955f5ac9cd89e3aeda1dbba0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1042329
Bug: 1052029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054296
Reviewed-by: Stephen McGruer \<smcgruer@chromium.org>
Commit-Queue: Stephen McGruer \<smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741119}

PR 21784 applied with additional changes from upstream: 9286332e9eeead5108ddcc38d846bbe59cdff045
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3347b53b7e90
[wpt PR 21784] - Revert "[Layout] SetNeedsLayout when an flex-item image loads", a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.