Profiling a fresh Android process via about:debugging uses wrong default profiler settings unless settings are toggled
Categories
(DevTools :: about:debugging, defect)
Tracking
(firefox75 fixed)
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: mstange, Assigned: gregtatum)
Details
Attachments
(1 file)
Steps to reproduce:
- Have an Android phone with Firefox Preview Nightly or GeckoView-example on it, with remote debugging enabled, and have it connected to your desktop machine with Firefox Nightly via USB. Start the Android browser app if it's not running.
- In Firefox Desktop, go to about:debugging, connect to the browser, open the profiling panel, and expand the Features pane. Do not click any of the checkboxes. On my machine, the first four feature checkboxes are checked, "Native Stacks" being one of them. I'm not sure whether this is the default or whether this was persisted somewhere.
- Start profiling, do something on the phone, and grab a profile.
Expected results:
Profiling should have been performed with the "stacks" feature enabled.
Actual results:
The info panel in the obtained profile reveals that this was not the case: Only the "js" and "threads" features were enabled.
Toggling any feature and starting profiling again applies the features correctly. Only when no features are toggled, wrong defaults are used.
Furthermore, once correct features have been applied, restarting the Android process makes the problem re-appear: after a restart of the app, wrong defaults are used again. (A restart is enough; uninstalling and re-installing is not required.)
|
Assignee | |
Comment 1•4 years ago
|
||
The default preset is "web-developer", and the DevTools panel was using that
preset over the custom values until at least one value was tweaked. This patch
changes the UI to only use the "custom" preset when in the DevTools panel. This
panel code will all be removed soon, so this is only a migration step.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
I did not include a test in these changes because:
- This panel's code is being deleted this month.
- We don't have remote profiling tests, since we don't have the infrastructure in place to remotely connect to a phone.
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2147bec7074 Do not use presets in the DevTools panel for performance-new; r=mstange
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•