1615420 - Don't ship DirectComposition in the places where Chrome blocks it

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

See disable_direct_composition in https://cs.chromium.org/chromium/src/gpu/config/gpu_driver_bug_list.json

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1615420. Disable DirectComposition in more situations.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9129197 [details]
Bug 1615420. Disable DirectComposition in more situations.

Beta/Release Uplift Approval Request

• User impact if declined: DirectComposition might be used in situations where it is buggy
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is pretty low risk. It just disables DirectComposition in a bunch of configurations to minimize initial shipping risk
• String changes made/needed:

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9129197 [details]
Bug 1615420. Disable DirectComposition in more situations.

Uplift approved for 74 beta 9, thanks.

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eb1a1b11639d

Comment 5

[Jeff Muizelaar [:jrmuizel]]

We need to land something like this in 75

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1615420. Disable DirectComposition on AMD and older Intel drivers on beta & release.

This is similar to a change that landed directly into 74. We don't want to
roll-out to these users yet and we don't want to have to think about it every
release.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08766c2e3d6a
Disable DirectComposition on AMD and older Intel drivers on beta & release. r=aosmond

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9132649 [details]
Bug 1615420. Disable DirectComposition on AMD and older Intel drivers on beta & release.

Beta/Release Uplift Approval Request

• User impact if declined: Higher risk that shipping DirectComposition will break things
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It just minimize the initial roll-out of DirectComposition. We don't know of any actual problems that it prevents.
• String changes made/needed:

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/08766c2e3d6a

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9129197 [details]
Bug 1615420. Disable DirectComposition in more situations.

approved for 75.0b5

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9129197 [details]
Bug 1615420. Disable DirectComposition in more situations.

Actually do we need both patches here? (one landed on 74, the other on 76)
They seem to conflict.

Comment 13

[Jeff Muizelaar [:jrmuizel]]

No, only https://phabricator.services.mozilla.com/D66453/ needs to land.

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/44089ee090c9