1615479 - `AttributeError: 'NoneType' object has no attribute 'get'` when using `mach try` with try syntax

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Cameron McCormack (:heycam)]

Since bug 1611989, I can't use try commands like this:

cam@zoo:/z/moz/central$ ./mach try -b do -p linux64 -u all -t none
No existing task history to clean up.
Error running mach:

    ['try', '-b', 'do', '-p', 'linux64', '-u', 'all', '-t', 'none']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'NoneType' object has no attribute 'get'

  File "/z/moz/central/tools/tryselect/mach_commands.py", line 211, in try_default
    'try', subcommand=sub, context=self._mach_context, argv=argv, **kwargs)
  File "/z/moz/central/python/mach/mach/registrar.py", line 152, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/z/moz/central/python/mach/mach/registrar.py", line 109, in _run_command_handler
    result = fn(**kwargs)
  File "/z/moz/central/tools/tryselect/mach_commands.py", line 412, in try_syntax
    return self.run(**kwargs)
  File "/z/moz/central/tools/tryselect/mach_commands.py", line 182, in run
    return mod.run(**kwargs)
  File "/z/moz/central/tools/tryselect/selectors/syntax.py", line 613, in run
    return at.run(**kwargs)
  File "/z/moz/central/tools/tryselect/selectors/syntax.py", line 608, in run
    closed_tree=kwargs["closed_tree"])
  File "/z/moz/central/tools/tryselect/push.py", line 144, in push_to_try
    display_push_estimates(try_task_config)
  File "/z/moz/central/tools/tryselect/push.py", line 123, in display_push_estimates
    dep_cache, task_labels_from_try_config(try_task_config), cache_dir)
  File "/z/moz/central/tools/tryselect/push.py", line 100, in task_labels_from_try_config
    return try_task_config.get("tasks", list())

Comment 1

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1615479 Cope with missing try_task_config during mach try estimate

Comment 2

[Simon Fraser [:sfraser] ⌚️GMT]

The patch is just to get things working - I'm unsure how I could display task estimates without the task config. Should there be a try_task_config for all the selectors?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/979fa94c9a81
Cope with missing try_task_config during mach try estimate r=ahal

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/979fa94c9a81