Closed Bug 1615489 Opened 4 years ago Closed 4 years ago

Refactor GenericGradient for conic-gradient support

Categories

(Core :: CSS Parsing and Computation, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

Since conic-gradient will need GenericGradient to take AngleOrPercentage over LengthPercentage for the items, the items field in the struct will need to be moved to GenericGradientKind. But that doesn't leave much shared fields between gradients in GenericGradient, so it's probably just worth merging it with GenericGradientKind.

https://searchfox.org/mozilla-central/source/servo/components/style/values/generics/image.rs#54

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/07fc980b7ed8
Refactor GenericGradient for conic-gradient support. r=emilio
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ab537e75aa6
Backed out changeset 07fc980b7ed8 for causing linux build bustages
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0721d0777474
Refactor GenericGradient for conic-gradient support. r=emilio
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/676fb29d8b43
Refactor GenericGradient for conic-gradient support. r=emilio
Flags: needinfo?(ntim.bugs)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Depends on: 1615876
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: