1615500 - Pending/discarded tabs may be loaded when moved via the tabs.move extension API

Status: NEW

(WebExtensions :: Frontend, defect, P3)

Description

[Thomas Arnett]

+++ This bug was initially created as a clone of Bug #1613577 +++

Steps to reproduce:

-1. Install the Tab Mover extension (currently version 7).
0. Have at least two windows, at least one of which has at least two tabs. The Auto Tab Discard extension is helpful but not required.

1. Select a window with at least two tabs.
2. Select any tab but the rightmost.
3. Discard the other tabs. If using the Auto Tab Discard extension, right-click on the active tab and select "Auto Tab Discard", then "Discard Other Tabs in This Window". Alternatively, restart Firefox and restore the session.
4. Shift-click on any tab to the right to highlight additional tabs.
5. Right-click on any highlighted tab and select "Tab Mover", then "Move to Window". Click on any window title in the menu.
6. Repeat, this time highlighting to the left instead of to the right.

Actual results:

The highlighted tabs are moved to the chosen window. If the leftmost highlighted tab is active, all moved pending/discarded tabs begin loading. If the rightmost highlighted tab is active, none do.

Expected results:

Pending/discarded tabs should remain pending/discarded when moved.

Comment 1

[Thomas Arnett]

tabs.move (in browser/components/extensions/parent/ext-tabs.js) appears to call gBrowser.adoptTab on each tab in sequence. Adopting the active tab last fixed bug 1521346 and appears to fix bug 1613577.

Comment 2

[Dão Gottwald [:dao]]

Please don't set a priority when filing bugs.

Comment 3

[Victor Carciu]

I was able to reproduce the issue following Step 6 from bug description. Also verified and the issue is reproducible on Latest Nightly(75.0a1).

I was not able to provide a regression range , because from unknown reasons, installation of Tab Mover extension is aborted("addon appear to be corrupt" message) starting with a build from 2019/04/21 and all builds newer than this where the addon can be installed are affected.

I will change the status of the bug from UNCONFIRMED to NEW.

Comment 4

[Worcester12345]

(In reply to Thomas Arnett from comment #0)

+++ This bug was initially created as a clone of Bug #1613577 +++

Steps to reproduce:

-1. Install the Tab Mover extension (currently version 7).
0. Have at least two windows, at least one of which has at least two tabs. The Auto Tab Discard extension is helpful but not required.

1. Select a window with at least two tabs.
2. Select any tab but the rightmost.
3. Discard the other tabs. If using the Auto Tab Discard extension, right-click on the active tab and select "Auto Tab Discard", then "Discard Other Tabs in This Window". Alternatively, restart Firefox and restore the session.
4. Shift-click on any tab to the right to highlight additional tabs.
5. Right-click on any highlighted tab and select "Tab Mover", then "Move to Window". Click on any window title in the menu.
6. Repeat, this time highlighting to the left instead of to the right.

Actual results:

The highlighted tabs are moved to the chosen window. If the leftmost highlighted tab is active, all moved pending/discarded tabs begin loading. If the rightmost highlighted tab is active, none do.

Expected results:

Pending/discarded tabs should remain pending/discarded when moved.

Can this bug be reproduced WITHOUT that extension?

Comment 5

[Worcester12345]

Should somebody add "Perf" key word?

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.