Closed Bug 1615519 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21795 - SharedWorker: Fire an error event when type or credentials mismatch

Categories

(Core :: DOM: Workers, task, P4)

Product:
Core
Component:
DOM: Workers
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21795 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21795
Details from upstream follow.

Eriko Kurimoto <elkurin@google.com> wrote:

SharedWorker: Fire an error event when type or credentials mismatch

This CL adds the step to check if type and credentials values are same
with these of matched SharedWorkerGlobalScope before connecting to it.

This is just added to the spec.
Spec issue: https://github.com/whatwg/html/issues/5235
Pull request: https://github.com/whatwg/html/pull/5258
WPT: https://github.com/web-platform-tests/wpt/pull/21651

This changes the behavior, and WPT is already added from the public pull
requests to WPT GitHub:
wpt/workers/shared-worker-options-mismatch.html

Bug: 1050438
Change-Id: I03232ff19db89560d99d3ddc6a25cdd8f1898222
Reviewed-on: https://chromium-review.googlesource.com/2041386
WPT-Export-Revision: 57ef96e4d4122c3abb44a5f2ccae0f953b1e46ae

Component: web-platform-tests → DOM: Workers
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 45 tests

Status Summary

Firefox

OK : 1
PASS: 2[GitHub] 46[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 2

Chrome

OK : 1
PASS: 2
FAIL: 2

Safari

OK : 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/workers/modules/shared-worker-import-failure.html
importScripts() on module worker should throw an exception.: FAIL (Chrome: FAIL, Safari: FAIL)
SharedWorker construction for a file URL should throw an exception.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d93a80c7e0b
[wpt PR 21795] - SharedWorker: Fire an error event when type or credentials mismatch, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3d93a80c7e0b

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.