1615559 - Perma browsertime AttributeError: 'bool' object has no attribute 'lower'

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=288890965&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VS-U2Cl4S52a8N8uGDZrVw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-02-14T09:49:09.209Z] 09:49:09 INFO - perftest-results-handler Info: parsing results from browsertime json
[task 2020-02-14T09:49:09.209Z] 09:49:09 ERROR - Traceback (most recent call last):
[task 2020-02-14T09:49:09.209Z] 09:49:09 INFO - File "/home/cltbld/tasks/task_1581653631/build/tests/raptor/raptor/raptor.py", line 193, in <module>
[task 2020-02-14T09:49:09.209Z] 09:49:09 INFO - main()
[task 2020-02-14T09:49:09.209Z] 09:49:09 INFO - File "/home/cltbld/tasks/task_1581653631/build/tests/raptor/raptor/raptor.py", line 143, in main
[task 2020-02-14T09:49:09.209Z] 09:49:09 INFO - success = raptor.run_tests(raptor_test_list, raptor_test_names)
[task 2020-02-14T09:49:09.209Z] 09:49:09 INFO - File "/home/cltbld/tasks/task_1581653631/build/tests/raptor/raptor/perftest.py", line 322, in run_tests
[task 2020-02-14T09:49:09.209Z] 09:49:09 INFO - return self.process_results(tests, test_names)
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - File "/home/cltbld/tasks/task_1581653631/build/tests/raptor/raptor/perftest.py", line 350, in process_results
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - return self.results_handler.summarize_and_output(self.config, tests, test_names)
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - File "/home/cltbld/tasks/task_1581653631/build/tests/raptor/raptor/results.py", line 642, in summarize_and_output
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - self.results.append(_new_benchmark_result(new_result))
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - File "/home/cltbld/tasks/task_1581653631/build/tests/raptor/raptor/results.py", line 620, in _new_benchmark_result
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - strtobool(test.get("subtest_lower_is_better", "True"))
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - File "/usr/lib/python2.7/distutils/util.py", line 319, in strtobool
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - val = string.lower(val)
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - File "/usr/lib/python2.7/string.py", line 228, in lower
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - return s.lower()
[task 2020-02-14T09:49:09.210Z] 09:49:09 INFO - AttributeError: 'bool' object has no attribute 'lower'
[task 2020-02-14T09:49:09.232Z] 09:49:09 ERROR - Return code: 1

Comment 1

[Marian Raiciof [:marauder]]

There are 2 ways to fix this regression:
[1]
Code changes : https://hg.mozilla.org/try/rev/dc5961a39f9c2257d917a2d1bd706ee355af2df2
Push to try : https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&tier=1%2C2%2C3&revision=03c2fee70a790caeea5913a6c056f1b3af44f2ae

[2]
Code changes : https://hg.mozilla.org/try/rev/d508ad0166191a717118a0cdff15a47d6b60b5cf
Push to try : https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=a6ee10a2a8a912745d0af831997667b3d05ce5f6&group_state=expanded

Comment 2

[Tarek Ziadé (:tarek)]

[1] does nor work. you can't use bool() on a string and expect it to work

>>> bool("True")
True
>>> bool("False")
True

Comment 3

[Intermittent Failures Robot]

1 failures in 4690 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1615559&startday=2020-02-10&endday=2020-02-16&tree=all

Comment 4

[Marian Raiciof [:marauder]]

Attachment: Bug 1615559 - Perma browsertime AttributeError: 'bool' object has no attribute 'lower'

Comment 5

[Marian Raiciof [:marauder]]

Hey Tarek, i changed the logic there and i am using a ternary operator now.

Push to try:
https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=0adef2aef5c5b41993cac71c957a02ec55fc8ec3&group_state=expanded

Comment 6

[Tarek Ziadé (:tarek)]

I am confused about the reason why we have to test if the value is a boolean or a string. why do we have this uncertainty ?
The current patch is fixing the error by trying both cases, but I think the real fix is to have a single type everywhere and the reason why it's not the case is the bug to find

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5dadc09e19b
Perma browsertime AttributeError: 'bool' object has no attribute 'lower' r=perftest-reviewers,sparky

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/d5dadc09e19b