1615685 - CFR Trigger: When a password is updated via the doorhanger

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Matthew N. [:MattN]]

Bug 1570372 added the newSavedLogin CFR trigger for when a new password is saved via a doorhanger. Now we want a similar trigger but for when a user updates a password via the doorhanger. This will also handle usernames additions after pwgen auto-saving.

We should be able to add a new LoginStats:LoginUpdateSaved observer notification in an else here and listen for it like we did in bug 1570372. We should add a test as well.

trigger.id: updatedSavedLogin

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1615685 - Trigger Sync CFR when a non-FxA user updates a saved password from doorhanger r=andreio

Comment 2

[Matthew N. [:MattN]]

Reminder to add the following to the save and update recipes on the server:

icon_class: "cfr-doorhanger-large-icon",

https://phabricator.services.mozilla.com/D65034#inline-392559

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c256f63b05ef
Trigger Sync CFR when a non-FxA user updates a saved password from doorhanger r=andreio

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c256f63b05ef

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 9130296 [details]
Bug 1615685 - Trigger Sync CFR when a non-FxA user updates a saved password from doorhanger r=andreio

Beta/Release Uplift Approval Request

• User impact if declined: Users won't be offered Sync after updating a password (which includes after password generation). We are promoting password manager improvements in Fx76 so this aligns with that push.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): New trigger for CFR that can be remotely enabled or disabled and re-uses a lot of existing code for the login save CFR
• String changes made/needed: None

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the “SAVE_LOGIN_72” CFR message is successfully displayed after a password was updated from the doorhanger.
Verified using the latest Firefox Nightly (77.0a1 Build ID - 20200408033650) installed on Windows 10 x64, Mac 10.15.4 and Ubuntu 18.04 x64.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9130296 [details]
Bug 1615685 - Trigger Sync CFR when a non-FxA user updates a saved password from doorhanger r=andreio

Approved for 76.0b3.

Comment 8

[Matthew N. [:MattN]]

(In reply to Marius Coman [:mcoman], Ecosystem QA from comment #6)

I have verified that the “SAVE_LOGIN_72” CFR message is successfully displayed after a password was updated from the doorhanger.

I'm not sure if the verification was correct since SAVE_LOGIN_72 is for the login save doorhanger and this bug was about adding a new UPDATE_LOGIN CFR for the login update doorhanger. That new CFR was deployed in bug 1615690.

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8225e94af7b0

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #8)

(In reply to Marius Coman [:mcoman], Ecosystem QA from comment #6)

I have verified that the “SAVE_LOGIN_72” CFR message is successfully displayed after a password was updated from the doorhanger.

I'm not sure if the verification was correct since SAVE_LOGIN_72 is for the login save doorhanger and this bug was about adding a new UPDATE_LOGIN CFR for the login update doorhanger. That new CFR was deployed in bug 1615690.

I have retested din issue using the following steps:

[Prerequisites]:

• Have a login saved for any website (E.G. https://www.facebook.com/).

[Steps to Reproduce]:

1. Open the browser with the profile from prerequisites.
2. Access the websites from the prerequisites.
3. Go to the password field and enter a different password from the one from the prerequisites.
4. Click the “Update” button from the “Update login” doorhanger.
5. Observe the right part of the “Address Bar”.

[Actual Results]:

• The CFR Recommendation button is displayed in the right part of the Address Bar.

[Notes]:

• If the “Turn on Sync” button from the CFR door hanger is clicked the “UPDATE_LOGIN” message from the “about:newtab#devtools” page is blocked.
• Tested using the latest Firefox Nightly (77.0a1 Build ID - 20200412214115) and latest Firefox Beta ( 76.0b4 Build ID - 20200412214314) installed on Windows 10 x64, Mac 10.15.4 and Ubuntu 18.04 x64.

Matthew, could you please confirm if the steps from above are correct in order to mark this enhancement as VERIFIED?

Comment 11

[Matthew N. [:MattN]]

Yes, that is better.

Comment 12

[Marius Coman [:mcoman], Ecosystem QA]

Thanks, Matthew! Based on comment 10 I am changing the status of this enhancement to VERIFIED.