1615700 - Calendar icon is missing in account central for "Create a new calendar"

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Paul Morris [:pmorris]]

The icon to the left of "Create a new calendar" is missing. I see what the problem is and should have a fix ready soon.

Comment 1

[Paul Morris [:pmorris]]

Attachment: part1-fix-missing-calendar-icon-0.patch

1 of 2: A recently renamed id that didn't get renamed in the CSS file. This fixes the missing icon.

Comment 2

[Paul Morris [:pmorris]]

Attachment: part2-move-calendar-icon-to-common-0.patch

2 of 2: I don't know why this icon was in the linux theme directory and not common, because it is used as a common theme element. Thought I'd fix this while I was here. Not tested with a full build yet, which I'll do when I get a chance to do a full build. (I'm using artifact builds at the moment.)

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9126804 [details] [diff] [review]
part2-move-calendar-icon-to-common-0.patch

We can dispose of calendar/base/themes/osx/images/cal-icon32.png and calendar/base/themes/windows/images/cal-icon24.png while we're at it. Not sure why it didn't happen with bug 1559176.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e8abde27176e
Fix missing calendar icon in account central. r=darktrojan
https://hg.mozilla.org/comm-central/rev/7f802938f14d
Move calendar icon from linux to common directory. r=darktrojan

Comment 5

[Geoff Lankow (:darktrojan)]

Pushed with the files from comment 3 removed.

Comment 6

[Rob Lemley [:rjl]]

I think we're missing an uplift somewhere?

e8abde27176e makes changes to calendar/base/themes/common/accountCentral.css which is not there yet on beta.

https://hg.mozilla.org/releases/comm-beta/file/4b04e68ccef08948b81a97983a6ad4eb4804781a/calendar/base/themes/common

Comment 7

[Magnus Melin [:mkmelin]]

That's the changeset for this bug, no?

Comment 8

[Paul Morris [:pmorris]]

Good catch rjl, I just took a look. It's not applying because beta doesn't have the patches from bug 1612166 yet, which rearranged the calendar skin files. There's also bug 1615422 which was a related follow up.

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: 1615700-part1-fix-missing-calendar-icon-beta.patch

This should be sufficient for beta, the rest can wait.

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 74.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/757c02a7bdfc