Enable base profiler for startup Talos tests
Categories
(Testing :: Talos, task, P3)
Tracking
(Not tracked)
People
(Reporter: mconley, Assigned: sparky)
References
Details
(Whiteboard: [fxperf:p1])
Attachments
(1 obsolete file)
The base profiler work in bug 1492121 makes it possible to get samples from before XPCOM starts up. This is useful data to have for things like startup performance.
So we should enable the base profiler for our startup performance tests.
Updated•3 years ago
|
Reporter | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Comment 2•3 years ago
|
||
Marking fxperf:p1 because there's already a patch, but given bug 1586939 should (hopefully soon) remove the need for this patch, I would otherwise have given this a lower priority.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7dee76ec48c4 Enable base profiler when profiling Talos startup tests. r=davehunt
Updated•3 years ago
|
Comment 4•3 years ago
|
||
bugherder |
Reporter | ||
Comment 5•3 years ago
|
||
This appears to have contributed to bug 1220362.
Hey malexandru, would you be able to back out 7dee76ec48c4 when you have a moment?
Comment 6•3 years ago
|
||
Done, thank you!
Backout by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5490c9f430b8 Backed out changeset 7dee76ec48c4 for causing Talos failures.
![]() |
||
Comment 8•3 years ago
|
||
Backout merged: https://hg.mozilla.org/mozilla-central/rev/5490c9f430b8
Comment 9•3 years ago
|
||
Hey Mike, I assume we still want that? Are you going to continue working on the bug?
Comment 10•3 years ago
|
||
Maybe we should simply wait for bug 1586939 to be fixed?
Comment 11•3 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #10)
Maybe we should simply wait for bug 1586939 to be fixed?
Gerald, maybe you can add some feedback here? Given that you know more about the ETA here. I'm fairly sure it can still wait for a moment.
Updated•3 years ago
|
Comment 12•3 years ago
|
||
Alright, I'll start tomorrow! Sorry for the delay.
Comment 13•3 years ago
|
||
Thanks. I assume we can mark it as dependent then.
Comment 14•3 years ago
|
||
Gerald, is there anything else we would have to do for Talos, or shall we dupe this bug to bug 1586939?
Comment 15•3 years ago
|
||
Henrik: Now that bug 1586939 has landed, Base Profiler should Just Work™!
I don't know how the profiler is activated in these tests. If you set the environment variable MOZ_PROFILER_STARTUP=1
before starting Firefox, the output profile should contain new tracks named "GeckoMain (pre-xul)" with profiling information from before the main Gecko Profiler start in XUL. E.g.: https://share.firefox.dev/36NLPpK
To calibrate expectations: At the moment it's only the main thread, and there are no markers and few labels, so you'll only see stack sampling during that time. Markers&labels could be added outside of XUL, through "BaseProfiler.h" functions.
Comment 16•3 years ago
|
||
Yes, I can see those tracks in the appropriate Talos jobs now that are related to profiling the startup. Here one example for the startup about:home paint:
Profile: https://share.firefox.dev/3cpxW2c
Mike or Florian, I assume that looks all fine now and we can close this bug as fixed?
Comment 17•3 years ago
|
||
Yes, looks good to me now! Thanks for checking the profiles :-).
Updated•3 years ago
|
Updated•3 years ago
|
Updated•4 months ago
|
Updated•4 months ago
|
Description
•