1615769 - Windows build fails with Windows SDK 10.0.17763.0

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masatoshi Kimura [:emk]]

78:51.78 In file included from e:/m/mozilla-unified/widget/windows/WindowsUIUtils.cpp:34:
78:51.82 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt\windows.ui.viewmanagement.h:267:
78:51.82 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Devices.Enumeration.h:267:
78:51.85 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Background.h:267:
78:51.88 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Activation.h:267:
78:51.89 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Appointments.AppointmentsProvider.h:267:
78:51.92 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Appointments.h:267:
78:51.98 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.System.h:267:
78:51.99 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.h:268:
78:52.05 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Core.h:270:
78:52.05 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Core.h:268:
78:52.08 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Input.h:269:
78:52.14 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Storage.Streams.h:267:
78:52.19 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Storage.h:269:
78:52.26 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Storage.Search.h:267:
78:52.33 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Data.Text.h:267:
78:52.41 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Text.Core.h:268:
78:52.45 D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Text.h(582,25): error: use of 'FontStretch' with tag type that does not match previous declaration
78:52.48                 typedef enum FontStretch : int FontStretch;
78:52.52                         ^
78:52.57 e:/m/mozilla-unified/obj-x86_64-pc-mingw32/dist/include/mozilla/FontPropertyTypes.h(187,7): note: previous use is here
78:52.60 class FontStretch final : public FontPropertyValue<uint16_t, 6, 0, 1000> {
78:52.65       ^
78:52.71 In file included from e:/m/mozilla-unified/widget/windows/WindowsUIUtils.cpp:34:
78:52.77 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt\windows.ui.viewmanagement.h:267:
78:52.81 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Devices.Enumeration.h:267:
78:52.87 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Background.h:267:
78:52.94 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Activation.h:267:
78:53.00 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Appointments.AppointmentsProvider.h:267:
78:53.07 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Appointments.h:267:
78:53.13 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.System.h:267:
78:53.20 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.h:268:
78:53.24 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.ApplicationModel.Core.h:270:
78:53.28 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Core.h:268:
78:53.33 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Input.h:269:
78:53.37 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Storage.Streams.h:267:
78:53.42 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Storage.h:269:
78:53.47 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Storage.Search.h:267:
78:53.53 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.Data.Text.h:267:
78:53.60 In file included from D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Text.Core.h:268:
78:53.65 D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Text.h(996,22): error: definition of type 'FontStretch' conflicts with typedef of the same name
78:53.70                 enum FontStretch : int
78:53.75                      ^
78:53.79 D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Text.h(582,48): note: 'FontStretch' declared here
78:53.83                 typedef enum FontStretch : int FontStretch;
78:53.89                                                ^
78:53.95 D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Text.h(1485,22): error: definition of type 'SelectionType' conflicts with typedef of the same name
78:54.02                 enum SelectionType : int
78:54.09                      ^
78:54.13 D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Text.h(747,50): note: 'SelectionType' declared here
78:54.18                 typedef enum SelectionType : int SelectionType;
78:54.25                                                  ^
78:54.32 D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Text.h(1904,24): error: definition of type 'FontWeight' conflicts with typedef of the same name
78:54.38                 struct FontWeight
78:54.45                        ^
78:54.51 D:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt/Windows.UI.Text.h(857,43): note: 'FontWeight' declared here
78:54.58                 typedef struct FontWeight FontWeight;

CI uses 10.0.17134.0.

Reverting https://hg.mozilla.org/mozilla-central/rev/edabd786a473e490f0e9ba8e0b6d905ac2c6313e fixed the issue.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

It seems those types have moved to other files after 17763 and thus not causing any failure on newer SDKs. (I'm using 18990 preview.) Could you try moving using namespace mozilla to line 62 and check it works?

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Kagami :saschanaz from comment #1)

It seems those types have moved to other files after 17763 and thus not causing any failure on newer SDKs. (I'm using 18990 preview.)

Automation uses older SDKs.
https://searchfox.org/mozilla-central/rev/174f1195ec740e8f17223b48018f7e14e6d4e40e/build/windows_toolchain.py#27

Could you try moving using namespace mozilla to line 62 and check it works?

I will try. Generally, you should not put using-directives before #includes.

Comment 3

[Masatoshi Kimura [:emk]]

(In reply to Kagami :saschanaz from comment #1)

Could you try moving using namespace mozilla to line 62 and check it works?

I moved using namespace mozilla to line 133 because moving to line 62 willl break MinGW builds. This change fixed the problem.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Bug 1615769 - Move `using namespace mozilla` in order to resolve conflicts with Windows headers. r?saschanaz

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1615769 - Fix build conflict with Windows SDK

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ff6c746997a
Move `using namespace mozilla` in order to resolve conflicts with Windows headers. r=saschanaz

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3ff6c746997a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for patch for Beta approval when you get a chance.

Comment 9

[Masatoshi Kimura [:emk]]

AFAIK the 74 beta branch does not include the offending change:
https://searchfox.org/mozilla-beta/rev/0efe3d5525a746addf8afa518e4ccaafec5e1f87/widget/windows/WindowsUIUtils.cpp#30,36

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Ah, got confused by the status flags in bug 1573029 :\