Closed Bug 1615869 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21820 - [LayoutNG] Generate first baseline for kInlineBlock baseline algorithm.

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21820 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21820
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[LayoutNG] Generate first baseline for kInlineBlock baseline algorithm.

In https://chromium-review.googlesource.com/c/chromium/src/+/1988376 I
simplified the logic a little too much.

We (occasionally) need the first-baseline of a child inside an
inline-block. We need this when we are aligning a list-marker.

This modifies the NGBaselineAlgorithmType::kInlineBlock to always
produce both the first and last baselines.

Bug: 1051181
Change-Id: I4844dfe44d3525a68ee8b8d7f0f50bd995de9367

Reviewed-on: https://chromium-review.googlesource.com/2057344
WPT-Export-Revision: 58e6a1b70650ba68f9f3aa39464d590dc88c14a5

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f1ee3df709e
[wpt PR 21820] - [LayoutNG] Generate first baseline for kInlineBlock baseline algorithm., a=testonly

https://hg.mozilla.org/mozilla-central/rev/7f1ee3df709e

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.