mach fluent-migration-test broken with `hg: parse error`
Categories
(Firefox Build System :: Mach Core, defect)
Tracking
(firefox75 fixed)
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: flod, Assigned: Pike)
Details
Attachments
(1 file)
Running any migration with mach fluent-migration-test results in an error
The details of the failure are as follows:
hglib.error.CommandError: (255, b'', b"hg: parse error at 4: invalid token\n(::b'73fe27379dfde6538465e587e1e266de1c05f5d7' - ::b'df3434923fd75e806c5d1d3777e9a6c288909489'\n ^ here)")
File "/home/flodolo/src/mozilla-unified/testing/mach_commands.py", line 844, in run_migration_tests
rv |= fmt.test_migration(self, obj_dir, **context)
File "/home/flodolo/src/mozilla-unified/python/l10n/test_fluent_migrations/fmt.py", line 148, in test_migration
messages = [l.desc for l in client.log('::{} - ::{}'.format(tip, old_tip))]
File "/home/flodolo/src/mozilla-unified/third_party/python/python-hglib/hglib/client.py", line 1075, in log
out = self.rawcommand(args)
File "/home/flodolo/src/mozilla-unified/third_party/python/python-hglib/hglib/client.py", line 246, in rawcommand
raise error.CommandError(args, ret, out, err)
I'm not exactly sure when I ran migration last time, but it can't be more than a week.
The version of hg installed is 5.3 (it was 5.2.1 before I tried updating to see if it solved the problem).
|
Reporter | |
Comment 1•4 years ago
|
||
Reverting the changes from bug 1612579 makes the command work again.
If I understand it correctly, client returns bytes, which messes up the string formatting. Using .decode() seems to work, but there are probably smarter ways to fix it.
messages = [l.desc.decode() for l in client.log('::{} - ::{}'.format(tip.decode(), old_tip.decode()))]
|
Assignee | |
Comment 2•4 years ago
|
||
Some left-overs to fix for str vs byte in code that's only executed if there are new changesets as part of the migration.
|
|
Assignee | |
Comment 3•4 years ago
|
||
This fixes str-vs-bytes in code paths that are only executed
with unapplied migrations, where we validate some parts of the
generated commits.
Pushed by axel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/829b6a21ebfa remaining str-byte differences in fluent migration tests, r=flod
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•