Closed Bug 1615884 Opened 4 years ago Closed 4 years ago

clang-format mercurial extension won't respect .clang-format-ignore

Categories

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
defect

Tracking

(firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: emk, Assigned: padenot)

References

Details

Attachments

(1 file)

Bug 1615884 - Handle Windows separators correctly when calling clang-format -d on Windows, while allowing writing path with '/' on the command-line. r?andi
47 bytes, text/x-phabricator-request
Details | Review

Steps to reproduce:

  1. Enable clang-format extension (./mach vcs-setup will do it for you.)
  2. Modify a test file under build/clang-plugin/tests.
  3. Create a new changeset: hg commit

Actual result:
clang-format extension will format the modified file and the test will break.

Expected result:
clang-format extension should not touch the file.

Type: task → defect
Priority: -- → P3
Assignee: nobody → padenot
Status: NEW → ASSIGNED
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9a15d3564b9
Handle Windows separators correctly when calling clang-format -d on Windows, while allowing writing path with '/' on the command-line. r=andi

https://hg.mozilla.org/mozilla-central/rev/f9a15d3564b9

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Regressions: 1673871
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: