Closed Bug 1615936 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21825 - WebSocketStream: Use a hwm of 1 for the readable

Categories

(Core :: Networking: WebSockets, task, P4)

Product:
Core
Component:
Networking: WebSockets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream][necko-triaged])

Sync web-platform-tests PR 21825 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21825
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:

WebSocketStream: Use a hwm of 1 for the readable

Initially WebSocketStream used a hwm of 0 for the ReadableStream that is
returned from the connected promise, but that resulted in poor
throughput when the application wasn't continuously reading.

Change the hwm of 1 so that up to one message will still be transferred
to the render process even when it is not inside a read() call.
Backpressure will still be applied if more than 1 message is in transit.

BUG=983030

Change-Id: I883d9e62b8465d45bc9b383db8f639fbf791c78d
Reviewed-on: https://chromium-review.googlesource.com/2054605
WPT-Export-Revision: 7fb1201a0212da05f948a1f637814fdc9c806281

Component: web-platform-tests → Networking: WebSockets
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 4
FAIL : 4

Chrome

OK : 4
PASS : 4

Safari

OK : 3
FAIL : 3
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/websockets/stream-tentative/backpressure-receive.any.html
backpressure should be applied to received messages: FAIL (Chrome: PASS, Safari: FAIL)
/websockets/stream-tentative/backpressure-receive.any.worker.html
backpressure should be applied to received messages: FAIL (Chrome: PASS, Safari: FAIL)
/websockets/stream-tentative/backpressure-receive.any.serviceworker.html
backpressure should be applied to received messages: FAIL (Chrome: PASS, Safari: FAIL)
/websockets/stream-tentative/backpressure-receive.any.sharedworker.html
backpressure should be applied to received messages: FAIL (Chrome: PASS)

Whiteboard: [wptsync downstream] → [wptsync downstream][necko-triaged]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d2b5be822478
[wpt PR 21825] - WebSocketStream: Use a hwm of 1 for the readable, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d2b5be822478

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.