Closed Bug 1615990 Opened 4 years ago Closed 4 years ago

[Thunderbird Telemetry] collect mail volumes: how many mails read

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 78.0

People

(Reporter: mkmelin, Assigned: rnons)

Details

Attachments

(1 file, 2 obsolete files)

How many mails are opened is an interesting data point, and useful to be able to quantify properties of read messages (e.g. encrypted or not).

Assignee: nobody → remotenonsense
Attached patch 1615990.patch (obsolete) — Splinter Review

Added a scalar probe to collect how many mails are read.

Attachment #9151408 - Flags: review?(mkmelin+mozilla)
Attached patch 1615990.patch (obsolete) — Splinter Review

Forgot to add test_mailTelemetry.js.

Attachment #9151408 - Attachment is obsolete: true
Attachment #9151408 - Flags: review?(mkmelin+mozilla)
Attachment #9151429 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9151429 [details] [diff] [review]
1615990.patch

Review of attachment 9151429 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/db/msgdb/src/nsMsgDatabase.cpp
@@ +2396,5 @@
>        if (threadHdr) threadHdr->MarkChildRead(bRead);
>      }
> +
> +#ifndef MOZ_SUITE
> +    if(bRead) {

I think this would be with a space:
if (bRead)

Anyway, it's good to run clang-format before finalizing the patch. 

./mach clang-format -p comm/mailnews/db/msgdb/src/nsMsgDatabase.cpp

If you see more changes than expected, you may have to copy the comm/.clang-format into the obj-dir so that it would pick up comm-central version.
Attachment #9151429 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 78.0
Attached patch 1615990.patchSplinter Review

Used clang-format to fix formatting, thx.

Attachment #9151429 - Attachment is obsolete: true
Attachment #9151629 - Flags: review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/02023407ac61
Collect how many mails are read. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: