Closed
Bug 1615990
Opened 4 years ago
Closed 4 years ago
[Thunderbird Telemetry] collect mail volumes: how many mails read
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 78.0
People
(Reporter: mkmelin, Assigned: rnons)
Details
Attachments
(1 file, 2 obsolete files)
3.23 KB,
patch
|
rnons
:
review+
|
Details | Diff | Splinter Review |
How many mails are opened is an interesting data point, and useful to be able to quantify properties of read messages (e.g. encrypted or not).
Reporter | ||
Updated•4 years ago
|
Assignee: nobody → remotenonsense
Assignee | ||
Comment 1•4 years ago
|
||
Added a scalar probe to collect how many mails are read.
Attachment #9151408 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 2•4 years ago
|
||
Forgot to add test_mailTelemetry.js.
Attachment #9151408 -
Attachment is obsolete: true
Attachment #9151408 -
Flags: review?(mkmelin+mozilla)
Attachment #9151429 -
Flags: review?(mkmelin+mozilla)
Reporter | ||
Comment 3•4 years ago
|
||
Comment on attachment 9151429 [details] [diff] [review] 1615990.patch Review of attachment 9151429 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/db/msgdb/src/nsMsgDatabase.cpp @@ +2396,5 @@ > if (threadHdr) threadHdr->MarkChildRead(bRead); > } > + > +#ifndef MOZ_SUITE > + if(bRead) { I think this would be with a space: if (bRead) Anyway, it's good to run clang-format before finalizing the patch. ./mach clang-format -p comm/mailnews/db/msgdb/src/nsMsgDatabase.cpp If you see more changes than expected, you may have to copy the comm/.clang-format into the obj-dir so that it would pick up comm-central version.
Attachment #9151429 -
Flags: review?(mkmelin+mozilla) → review+
Reporter | ||
Updated•4 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 78.0
Assignee | ||
Comment 4•4 years ago
|
||
Used clang-format
to fix formatting, thx.
Attachment #9151429 -
Attachment is obsolete: true
Attachment #9151629 -
Flags: review+
Reporter | ||
Updated•4 years ago
|
Keywords: checkin-needed-tb
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/02023407ac61
Collect how many mails are read. r=mkmelin
You need to log in
before you can comment on or make changes to this bug.
Description
•