1616010 - maven-lambda doesn't manage generate maven-metadata.xml for tooling-glean-gradle

Status: VERIFIED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Johan Lorenzo [:jlorenzo]]

In [1], :mdroettboom published tooling-glean-gradle to maven.mozilla.org and more notably snapshots.maven.m.o[2]. Sadly, there is maven-metadata.xml generated at [3].

I looked at the logs of maven-lambda, and here what comes out:

2020/02/16/[$LATEST]a67d996887af4f24a5d2469b122e7015 2020-02-16T19:17:05.164Z 2020-02-16T19:17:08.201Z .pom in version folder: ['maven2/org/mozilla/components/tooling-glean-gradle/33.0.0-SNAPSHOT/tooling-glean-gradle-33.0.0-20200214.190127-1.pom', 'maven2/org/mozilla/components/tooling-glean-gradle/33.0.0-SNAPSHOT/tooling-glean-gradle-33.0.0-20200215.130131-1.pom', 'maven2/org/mozilla/components/tooling-glean-gradle/33.0.0-SNAPSHOT/tooling-glean-gradle-33.0.0-20200215.190052-1.pom', 'maven2/org/mozilla/components/tooling-glean-gradle/33.0.0-SNAPSHOT/tooling-glean-gradle-33.0.0-20200216.130105-1.pom', 'maven2/org/mozilla/components/tooling-glean-gradle/33.0.0-SNAPSHOT/tooling-glean-gradle-33.0.0-20200216.190116-1.pom']
2020/02/16/[$LATEST]a67d996887af4f24a5d2469b122e7015 2020-02-16T19:17:05.207Z 2020-02-16T19:17:08.201Z 'NoneType' object has no attribute 'text'
2020/02/16/[$LATEST]a67d996887af4f24a5d2469b122e7015 2020-02-16T19:17:05.208Z 2020-02-16T19:17:08.201Z 'NoneType' object has no attribute 'text': AttributeError
Traceback (most recent call last):
  File "/var/task/metadata.py", line 65, in lambda_handler
    metadata_function=generate_snapshot_listing_metadata
  File "/var/task/metadata.py", line 119, in craft_and_upload_maven_metadata
    metadata = metadata_function(bucket_name, pom_files)
  File "/var/task/metadata.py", line 181, in generate_snapshot_listing_metadata
    snapshots_metadata = get_snapshots_metadata(bucket_name, pom_files_keys)
  File "/var/task/metadata.py", line 227, in get_snapshots_metadata
    } for key, file_name in pom_keys_and_file_names]
  File "/var/task/metadata.py", line 227, in <listcomp>
    } for key, file_name in pom_keys_and_file_names]
  File "/var/task/metadata.py", line 244, in _fetch_extension_from_pom_file_content
    return packaging_element.text
AttributeError: 'NoneType' object has no attribute 'text'

This line[4] errors out because the glean POM file[5] doesn't specify a packaging entry like another android-component does[6]. The root cause is: glean ships a jar file instead of an aar one. jar being the first file format supported by gradle, it doesn't need to specify packaging at all. Thus, let's change maven-lambda gracefully return a value.

[1] https://github.com/mozilla-mobile/android-components/pull/5476
[2] https://snapshots.maven.mozilla.org/
[3] https://snapshots.maven.mozilla.org/?prefix=maven2/org/mozilla/components/tooling-glean-gradle/33.0.0-SNAPSHOT/
[4] https://github.com/mozilla-releng/maven-lambda/blob/49b36dbd6a604fc505a518dd52d03e671427b85f/maven_lambda/metadata.py#L244
[5] https://snapshots.maven.mozilla.org/maven2/org/mozilla/components/tooling-glean-gradle/33.0.0-SNAPSHOT/tooling-glean-gradle-33.0.0-20200216.190116-1.pom
[6] For instance: https://snapshots.maven.mozilla.org/maven2/org/mozilla/components/browser-engine-gecko-nightly/33.0.0-SNAPSHOT/browser-engine-gecko-nightly-33.0.0-20200216.190116-1.pom

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: [maven-lambda] Do not error out when pom file does not contain packaging element

Comment 2

[Johan Lorenzo [:jlorenzo]]

Hi Jeremy!

Would you have some cycles to deploy https://community-tc.services.mozilla.com/api/queue/v1/task/JzwjTayMR9OUJjdXaS1v4Q/runs/0/artifacts/public/build/function.zip ?

This will fix this issue in production 🙂

Comment 3

[Michael Droettboom [:mdroettboom]]

Thanks for the fix. Do we have an ETA on when this will deploy to production?

Comment 4

[Jeremy Orem [:oremj]]

This had been deployed.

Comment 5

[Johan Lorenzo [:jlorenzo]]

And I confirm it works! https://snapshots.maven.mozilla.org/maven2/org/mozilla/components/tooling-glean-gradle/35.0.0-SNAPSHOT/maven-metadata.xml

Thank you very much for your help, Jeremy!