Closed Bug 1616039 Opened 5 years ago Closed 5 years ago

Port |Bug 542032 - Don't look up prefs on every tab & window close| and |Bug 758138 - Current pref value is read before registering the observer| to SeaMonkey

Categories

(SeaMonkey :: Session Restore, task)

Product:
SeaMonkey
Component:
Session Restore
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.73
Tracking Flags:
Tracking Status
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.2)

Attachments

(1 file, 1 obsolete file)

Port changes to pref look ups in sessionstore v1.1
6.49 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Port to SeaMonkey:

  • Bug 542032 - Don't look up prefs on every tab & window close
  • Bug 758138 - Current pref value is read before registering the observer

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.2
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9127168 - Flags: review?(frgrahl)
Attachment #9127168 - Flags: approval-comm-release?
Attachment #9127168 - Flags: approval-comm-esr60?

Updated patch to include whole of first bug plus partial reversal from Bug 758138.

Attachment #9127168 - Attachment is obsolete: true
Attachment #9127168 - Flags: review?(frgrahl)
Attachment #9127168 - Flags: approval-comm-release?
Attachment #9127168 - Flags: approval-comm-esr60?
Summary: Port |Bug 542032 - Don't look up prefs on every tab & window close| to SeaMonkey → Port |Bug 542032 - Don't look up prefs on every tab & window close| and |Bug 758138 - Current pref value is read before registering the observer| to SeaMonkey
Attachment #9134627 - Flags: review?(frgrahl)
Attachment #9134627 - Flags: approval-comm-release?
Attachment #9134627 - Flags: approval-comm-esr60?
Blocks: 1616154
Comment on attachment 9134627 [details] [diff] [review] Port changes to pref look ups in sessionstore v1.1 LGTM
Attachment #9134627 - Flags: review?(frgrahl)
Attachment #9134627 - Flags: review+
Attachment #9134627 - Flags: approval-comm-release?
Attachment #9134627 - Flags: approval-comm-release+
Attachment #9134627 - Flags: approval-comm-esr60?
Attachment #9134627 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e75299a8d3c2
Port |Bug 542032 - Don't look up prefs on every tab & window close| and |Bug 758138 - Current pref value is read before registering the observer| to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
status-seamonkey2.53: --- → affected
status-seamonkey2.57esr: --- → affected
Target Milestone: --- → seamonkey 2.73
status-seamonkey2.53: affected → fixed
status-seamonkey2.57esr: affected → fixed
Whiteboard: SM2.53.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: