1616132 - getProgramParameter(ATTACHED_SHADERS) always returns 2

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

There are always two valid slots, but we need to check the slot contents for non-nulls.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1616132 - ATTACHED_SHADERS must count non-null slots.

It was always returning 2.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Added a test upstream:
https://github.com/KhronosGroup/WebGL/pull/3023

Comment 3

[Kelsey Gilbert [:jgilbert]]

[Tracking Requested - why for this release]: This fixes YouTube 360 videos.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c906f7b0f8dc
ATTACHED_SHADERS must count non-null slots. r=lsalzman

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c906f7b0f8dc

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9127154 [details]
Bug 1616132 - ATTACHED_SHADERS must count non-null slots.

Beta/Release Uplift Approval Request

• User impact if declined: YouTube 360 video broken in Firefox
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Really simple fix, and we're adding tests for it so we don't regress again.
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9127154 [details]
Bug 1616132 - ATTACHED_SHADERS must count non-null slots.

Fixes a webgl regression causing real-world site issues. Approved for 74.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4728e224533e

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.