Closed
Bug 1616142
Opened 6 years ago
Closed 6 years ago
browser.compose.begin* functions should wait for the compose window to exist before returning
Categories
(Thunderbird :: Add-Ons: Extensions API, enhancement)
Thunderbird
Add-Ons: Extensions API
Tracking
(thunderbird74 fixed)
RESOLVED
FIXED
Thunderbird 75.0
| Tracking | Status | |
|---|---|---|
| thunderbird74 | --- | fixed |
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
|
4.43 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
It'd be useful, especially for tests, if we knew that a compose window existed before doing the next thing. Currently we just call OpenComposeWindow/OpenComposeWindowWithParams and return immediately. We should wait.
| Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9127196 -
Flags: review?(mkmelin+mozilla)
Comment 2•6 years ago
|
||
Comment on attachment 9127196 [details] [diff] [review]
1616142-compose-window-wait-1.diff
Review of attachment 9127196 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM! r=mkmelin
Attachment #9127196 -
Flags: review?(mkmelin+mozilla) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f7de7594255d
Wait for compose window to open before returning from compose API functions. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
| Assignee | ||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 75.0
| Assignee | ||
Comment 4•6 years ago
|
||
status-thunderbird74:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•