1616186 - Crash in [@ mozilla::scache::StartupCache::MaybeInitShutdownWrite]

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Gabriele Svelto [:gsvelto]]

This bug is for crash report bp-d1a8ade7-081c-40d9-96f8-9bd9a0200217.

Top 10 frames of crashing thread:

0 libxul.so mozilla::scache::StartupCache::MaybeInitShutdownWrite startupcache/StartupCache.cpp:598
1 libxul.so nsAppStartup::Quit toolkit/components/startup/nsAppStartup.cpp:367
2 libxul.so nsNativeAppSupportUnix::DieCB toolkit/xre/nsNativeAppSupportUnix.cpp:356
3 libSM.so.6.0.1 _SmcProcessMessage 
4 libICE.so.6.3.0 IceProcessMessages 
5 libxul.so ice_iochannel_watch toolkit/xre/nsNativeAppSupportUnix.cpp:182
6 libglib-2.0.so.0.6200.4 g_main_context_dispatch 
7 libglib-2.0.so.0.6200.4 g_main_context_acquire 
8 libglib-2.0.so.0.6200.4 g_main_context_iteration 
9 libxul.so nsBaseAppShell::OnProcessNextEvent widget/nsBaseAppShell.cpp:259

NULL-pointer dereference of the this pointer from the looks of it, probably a regression from bug 1607505.

Doug can you have a look?

Comment 1

[Doug Thayer [:dthayer] (he/him)]

Attachment: Bug 1616186 - Don't try to write StartupCache if it doesn't exist r?froydnj

The exact circumstances of how this is showing up in the wild aren't
clear - there seem to be a couple of ways we can get here. However it
all revolves around early shutdowns (i.e., from the select profile popup)

• before the StartupCache is ever initialized. In any case, the solution
  shouldn't change based on the exact circumstances - if we don't have a
  StartupCache, there's no need to write one. Also, don't bother lazy
  initializing it if it doesn't exist yet.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/679b52ee70c7
Don't try to write StartupCache if it doesn't exist r=froydnj

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/679b52ee70c7