1616220 - Permafailing browser_tabCloseProbes.js | Uncaught exception - at test/tabs/browser_tabCloseProbes.js:21 - TypeError: can't access property "values", snapshot is undefined when Gecko version increases to 76 on 2020-03-09

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:
Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=85bec4ee2a5eb84bbd3842824589f306681e11de&searchStr=browser-chrome&selectedJob=289320215

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289320215&repo=try&lineNumber=3161

[task 2020-02-18T10:33:44.654Z] 10:33:44 INFO - TEST-START | browser/base/content/test/tabs/browser_tabCloseProbes.js
[task 2020-02-18T10:33:45.339Z] 10:33:45 INFO - TEST-INFO | started process screentopng
[task 2020-02-18T10:33:45.861Z] 10:33:45 INFO - TEST-INFO | screentopng: exit 0
[task 2020-02-18T10:33:45.862Z] 10:33:45 INFO - Buffered messages logged at 10:33:44
[task 2020-02-18T10:33:45.862Z] 10:33:45 INFO - Entering test bound setup
[task 2020-02-18T10:33:45.863Z] 10:33:45 INFO - Leaving test bound setup
[task 2020-02-18T10:33:45.863Z] 10:33:45 INFO - Entering test bound test_close_time_anim_probe
[task 2020-02-18T10:33:45.864Z] 10:33:45 INFO - Buffered messages finished
[task 2020-02-18T10:33:45.865Z] 10:33:45 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_tabCloseProbes.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js:21 - TypeError: can't access property "values", snapshot is undefined
[task 2020-02-18T10:33:45.865Z] 10:33:45 INFO - Stack trace:
[task 2020-02-18T10:33:45.865Z] 10:33:45 INFO - snapshotCount@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js:21:3
[task 2020-02-18T10:33:45.865Z] 10:33:45 INFO - assertCount@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js:38:5
[task 2020-02-18T10:33:45.865Z] 10:33:45 INFO - test_close_time_anim_probe@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js:85:14
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:914:23
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - Leaving test bound test_close_time_anim_probe
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - Entering test bound test_close_time_no_anim_probe
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - GECKO(2326) | -----------------------------------------------------
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - GECKO(2326) | Suppressions used:
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - GECKO(2326) | count bytes template
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - GECKO(2326) | 27 832 nsComponentManagerImpl
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - GECKO(2326) | 611 17713 libfontconfig.so
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - GECKO(2326) | 1 29 libglib-2.0.so
[task 2020-02-18T10:33:45.866Z] 10:33:45 INFO - GECKO(2326) | -----------------------------------------------------
[task 2020-02-18T10:33:45.921Z] 10:33:45 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-18T10:33:45.922Z] 10:33:45 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_tabCloseProbes.js | Uncaught exception - Collected value should become 1. - threw exception: TypeError: can't access property "values", snapshot is undefined
[task 2020-02-18T10:33:45.922Z] 10:33:45 INFO - Leaving test bound test_close_time_no_anim_probe
[task 2020-02-18T10:33:45.942Z] 10:33:45 INFO - GECKO(2326) | MEMORY STAT | vsize 20975731MB | residentFast 1360MB
[task 2020-02-18T10:33:45.944Z] 10:33:45 INFO - TEST-OK | browser/base/content/test/tabs/browser_tabCloseProbes.js | took 1282ms

Comment 1

[Dão Gottwald [:dao]]

Mike, FX_TAB_CLOSE_TIME_NO_ANIM_MS is set to expire in 76. Should it be renewed or removed?

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Attachment: Probe renewal form for FX_TAB_CLOSE_PERMIT_UNLOAD_TIME_MS.md

Comment 4

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Attachment: Bug 1616220 - Bump FX_TAB_CLOSE_TIME_NO_ANIM_MS expiry to version 80. r?dao, data-review=mmccorquodale

Comment 5

[Megan McCorquodale]

Comment on attachment 9127364 [details]
Probe renewal form for FX_TAB_CLOSE_PERMIT_UNLOAD_TIME_MS.md


    1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?
Yes. 
    2. Is the data collection covered by the existing Firefox Privacy Notice?
Yes. 

--- 
data-review +

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c73bb7b4a284
Bump FX_TAB_CLOSE_TIME_NO_ANIM_MS expiry to version 80. r=dao, data-review=mmccorquodale

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c73bb7b4a284

Comment 8

[Alexandru Michis [:malexandru]]

Mike,
This is still appearing in today's version increase simulation:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291264215&repo=try&lineNumber=13399
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291265527&repo=try&lineNumber=3571

Central as version increase simulation:https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=06a564ecc52c35803f79dbfee3e599165a90c1b9&selectedJob=291264215

Could you please take a look?

Comment 9

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Ugh, careless of me. I bumped the wrong probe expiry. The one I did bump I ended up filing a separate bug for in bug 1617671. What a mess.

Okay, I think I'm going to re-open this bug, and we can land some follow-ups to extend the probe I really meant to in the first place. :/

Comment 11

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Attachment: Probe renewal form for FX_TAB_CLOSE_TIME_NO_ANIM_MS.md

Comment 12

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Attachment: Bug 1616220 - Extend FX_TAB_CLOSE_TIME_NO_ANIM_MS probe to version 80 to fix browser_tabCloseProbes.js test. r?dao

Revision c73bb7b4a284 was originally intended to do this, but accidentally extended a
separate but related probe. Unfortunately, extending that probe didn't fix the original
problem, which is a test failure on uplift simulation.

This patch actuall extends the FX_TAB_CLOSE_TIME_NO_ANIM_MS probe to version 80.

Comment 13

[Chris H-C :chutten]

Comment on attachment 9130138 [details]
Probe renewal form for FX_TAB_CLOSE_TIME_NO_ANIM_MS.md

    Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

    Is the data collection covered by the existing Firefox Privacy Notice?

Yes.

---
Result: datareview+

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c914443c934
Extend FX_TAB_CLOSE_TIME_NO_ANIM_MS probe to version 80 to fix browser_tabCloseProbes.js test. r=dao

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1c914443c934

Comment 16

[Alexandru Michis [:malexandru]]

A version increase try run shows that the patch works:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&classifiedState=unclassified&revision=4e56949b5ba0564792bf54a782219a0fab856d1a&group_state=expanded

Setting this as verified fixed.