1616225 - Apparent copy-paste error in table selection code

Status: NEW

(Core :: DOM: Selection, defect, P3)

Description

[Jonathan Kew [:jfkthame]]

This code looks broken to me:

// Move to next cell in cellmap, skipping spanned locations
if (aTarget == TableSelection::Row)
  colIndex += tableFrame->GetEffectiveRowSpanAt(rowIndex, colIndex);
else
  rowIndex += tableFrame->GetEffectiveRowSpanAt(rowIndex, colIndex);

Note the use of GetEffectiveRowSpanAt in both lines; ISTM one of these should refer to Col rather than Row.

Looking back, this seems to have originated in bug 781409, where the code was changed from

if (aTarget == nsISelectionPrivate::TABLESELECTION_ROW)
  colIndex += actualColSpan;
else
  rowIndex += actualRowSpan;

using values retrieved from tableLayout->GetCellDataAt() earlier to the current form calling GetEffective... methods.

(I'm not sure I know how to create a test for this, as I don't know much about how table selection is supposed to behave. Apparently no existing tests depend on correctness here.)