1616262 - Prevent early crashes in non-content/plugin processes from crashing the main process

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P1)

Description

[Gabriele Svelto [:gsvelto]]

The fix for bug 1610566 turned out not to be complete. While we don't hit an assertion anymore with certain process types (such as the GPU process) we might cause a NULL-pointer dereference if the process crashes early enough.

This is because the parent object calls GenerateCrashReport() with a NULL parameter for the minidump ID (since it doesn't care about it), but the code in HandleOrphanedMinidump() assumes that if a minidump was taken correctly we care about its ID.

Comment 1

[Gabriele Svelto [:gsvelto]]

Let's fix this right now.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1616262 - Prevent the main process from crashing in response to an early GPU/VR/Socket/RDD process crash r=froydnj

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfa84ca1d41c
Prevent the main process from crashing in response to an early GPU/VR/Socket/RDD process crash r=froydnj

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/cfa84ca1d41c